Accept queue keyword arg in Connection_getJobs#47
Open
guilhermgonzaga wants to merge 1 commit intoOpenPrinting:masterfrom
Open
Accept queue keyword arg in Connection_getJobs#47guilhermgonzaga wants to merge 1 commit intoOpenPrinting:masterfrom
guilhermgonzaga wants to merge 1 commit intoOpenPrinting:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
This PR is based on the proposal #4, but I thought a better approach to it would be to use the string library rather than regex. Still, there are some technicalities to discuss.
First is queue name length. In the very unlikely case that the limit (998 bytes) is reached, trimming the queue name should be worse than failing, since it may still be a valid request, but not the intended one.
Second, I found that RFC 3986 section 3.3 specifies a few more valid characters in the path component, depending on the rule used. Since all IPP URIs are absolute (RFC 3510 section 4.1), the following should be valid:
-._~!$&'()*+,;=:@I did create a few dummy printers in Ubuntu using all of those chars, except
', which lp rejected, and I was able to send jobs and query them with getJobs in Python.Close #4.