fix: lyon survey post submit duplicate message#981
Draft
BarbaraOliveira13 wants to merge 15 commits intodevelopfrom
Draft
fix: lyon survey post submit duplicate message#981BarbaraOliveira13 wants to merge 15 commits intodevelopfrom
BarbaraOliveira13 wants to merge 15 commits intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 Description
BUG
After a first survey submission, an 'already answered" message was displayed simultaneously with the success flash message. It is confusing.
.to have_contentto.to have_no_contentline 79FIX
Override
decidim survey show viewto fix the UX bug, with adding a condition to hide "already answered" block when success flash message in present: [line 34]&& flash[:notice].blank?.Testing
📌 Related Issues
[Link your PR to an issue
nightly.decidim.org— an upstream issue hasbeen opened: Survey shows "already answered" block simultaneously with success flash after first submission decidim/decidim#16660
Tasks
🛠️ If your PR introduces or updates an Override
📷 Screenshots
Extra information