Fix CGAffineTransform on non-Darwin platform#5
Merged
Kyle-Ye merged 4 commits intoOpenSwiftUIProject:mainfrom Oct 19, 2025
Dark-Existed:main
Merged
Fix CGAffineTransform on non-Darwin platform#5Kyle-Ye merged 4 commits intoOpenSwiftUIProject:mainfrom Dark-Existed:main
Kyle-Ye merged 4 commits intoOpenSwiftUIProject:mainfrom
Dark-Existed:main
Conversation
Kyle-Ye
requested changes
Oct 9, 2025
Contributor
Kyle-Ye
left a comment
There was a problem hiding this comment.
It is strange that your PR does not trigger the repo's workflow.
The macOS and Ubuntu is passing. But it will fail the compatibility test suite (which set OPENCOREGRAPHICS_COREGRAPHICS to 0 on macOS)
The error is
CGAffineTransformTests.swift:111:18: error: ambiguous use of 'init(a:b:c:d:tx:ty:)'
Contributor
Author
|
It now works with the compatibility test suite. |
Contributor
|
I've triggered the pipeline check. And I'll give a final review and merge this week if possible. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 71.78% 73.06% +1.27%
==========================================
Files 9 10 +1
Lines 638 672 +34
==========================================
+ Hits 458 491 +33
- Misses 180 181 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.