Add KeyValue callback handlers for get and scan.#59
Open
lzheng wants to merge 2 commits intoOpenTSDB:masterfrom
Open
Add KeyValue callback handlers for get and scan.#59lzheng wants to merge 2 commits intoOpenTSDB:masterfrom
lzheng wants to merge 2 commits intoOpenTSDB:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tsuna @canoeberry @jasonculverhouse
This is a merge back of what Jonathan created at: Flipboard@ef2c07b
I did several touch-ups to make sure the change can be integrated back to OpenTSDB/asynchbase.
The change will enable callers for scanner and get to specify a callback handler to process KeyValue as they are coming. Thus caller can decide if the value should be saved or discarded. It is a great way to save some memories and avoid too much GCs.
I still have a couple of questions: