Remove invalid Traefik Middleware stickySession resource from Orchestra#247
Open
spantaleev wants to merge 1 commit intoOpenUnison:masterfrom
Open
Remove invalid Traefik Middleware stickySession resource from Orchestra#247spantaleev wants to merge 1 commit intoOpenUnison:masterfrom
spantaleev wants to merge 1 commit intoOpenUnison:masterfrom
Conversation
Contributor
|
@spantaleev good catch. looks like it got by because the CRD doesn't enforce extra attributes. Please bump the orchestra version too before i can merge |
The Traefik template currently emits: ```yml apiVersion: traefik.io/v1alpha1 kind: Middleware metadata: name: sticky-cookie spec: stickySession: ... ``` This fails validation/apply against Traefik CRDs because stickySession is not a valid top-level field in middlewares.traefik.io (v1alpha1). Important distinction: - Traefik does support sticky sessions, but via sticky on service/load-balancer definitions (e.g. `IngressRoute` route services), not as Middleware `spec.stickySession`. - In this template, sticky behavior is already configured correctly on IngressRoute service entries (`routes[].services[].sticky.cookie`), so removing the extra Middleware is safe and preserves affinity behavior. References: - Traefik Kubernetes CRD definitions (v2.10, v3.6): sticky is defined in service contexts; no Middleware `stickySession` - https://raw.githubusercontent.com/traefik/traefik/v2.10/docs/content/reference/dynamic-configuration/kubernetes-crd-definition-v1.yml - https://raw.githubusercontent.com/traefik/traefik/v3.6/docs/content/reference/dynamic-configuration/kubernetes-crd-definition-v1.yml - Traefik service sticky-sessions docs: https://doc.traefik.io/traefik/v3.6/reference/routing-configuration/http/load-balancing/service/#sticky-sessions This regression seems to have been introduced in commit 6337576 where the `sticky-cookie` Middleware was added.
spantaleev
force-pushed
the
fix/traefik-sticky-middleware
branch
from
42e3b06 to
63b755d
Compare
Contributor
Author
|
I've also bumped the Orchestra version now. Sorry for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Traefik template currently emits:
This fails validation/apply against Traefik CRDs because stickySession is not a valid top-level field in middlewares.traefik.io (v1alpha1).
Important distinction:
IngressRouteroute services), not as Middlewarespec.stickySession.routes[].services[].sticky.cookie), so removing the extra Middleware is safe and preserves affinity behavior.References:
Traefik Kubernetes CRD definitions (v2.10, v3.6): sticky is defined in service contexts; no Middleware
stickySessionTraefik service sticky-sessions docs: https://doc.traefik.io/traefik/v3.6/reference/routing-configuration/http/load-balancing/service/#sticky-sessions
This regression seems to have been introduced in commit 6337576 where the
sticky-cookieMiddleware was added.