Skip to content

Conversation

@Spartan322
Copy link
Member

@Spartan322 Spartan322 commented Jan 1, 2026

Move early hotkey bind handling into KeychainShortcutEdit
Add hotkey reset warning

This simplifies the handling of hotkeys, however due to technical limitations on loading hotkeys in the game session instancing, Keychain's reset functionality for hotkeys presumes the initially loaded value is the default until it loads into a game session.

@Spartan322 Spartan322 added enhancement topic:gui dependencies Pull requests that update a dependency file labels Jan 1, 2026
@Spartan322 Spartan322 marked this pull request as draft January 1, 2026 14:29
@Spartan322 Spartan322 marked this pull request as ready for review January 1, 2026 14:54
@Spartan322 Spartan322 force-pushed the update/keychain branch 3 times, most recently from 78b0143 to 8ad25ac Compare January 1, 2026 17:15
Move early hotkey bind handling into KeychainShortcutEdit
Add hotkey reset warning
Copy link
Contributor

@wvpm wvpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mouse dragging code surprised me a bit, considering this is a PR to update keychain.
Still looks okay

@Spartan322 Spartan322 merged commit 10a0cbf into master Jan 27, 2026
20 checks passed
@Spartan322 Spartan322 deleted the update/keychain branch January 27, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement topic:gui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants