Multiple NIC for Transmission

[sunilnom]

Description

Checklist

Code Quality

• Code follows project style guidelines
• No unnecessary debug logs or commented-out code
• No hardcoded values / secrets

Testing

• Unit test added/modified accordingly
• Perform manual basic sanity testing at system level

Review Readiness

• PR title and description are clear and meaningful
• Story/Task IDs are linked

Documentation

• README or relevant docs updated (if applicable)

Security

• No sensitive data exposed (keys, passwords, tokens)
• Input validation added where needed

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Documentation content changes
• Testing
• Other... Please describe:

[Copilot]

Pull request overview

This PR updates dvledtx’s configuration model and TX plumbing to support mapping sessions to multiple NICs (via nic_index) and introduces optional decode-time scaling (scale_width/scale_height) with corresponding validation and documentation/config fixture updates.

Changes:

• Refactor config parsing/validation to support multiple interfaces[] entries and per-session nic_index, plus a new tx_video block for transmission/scaling parameters.
• Add optional scaling support and propagate “effective” (scaled) dimensions through decoder and crop logic.
• Update MTL/FFmpeg TX paths, tests, and config fixtures to use the new NIC/session allocation model.

Reviewed changes

Copilot reviewed 27 out of 28 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
tests/test_session_manager.c	Adjust test app setup to allocate NIC/session arrays and use nics[0].
tests/test_main.c	Update stubs and resolve_ip_addrs tests to use nics[] and dynamic allocation.
tests/test_ffmpeg_watchdog.c	Update test app setup to use dynamic NIC/session arrays.
tests/test_ffmpeg_tx.c	Update FFmpeg TX unit test setup to use nics[].
tests/test_ffmpeg_tx_mock.c	Update FFmpeg TX mock tests for dynamic session arrays sizing.
tests/test_ffmpeg_decoder_mock.c	Update decoder mock test setup to use nics[].
tests/test_config_reader.c	Update tests for dynamic config arrays and add scaling-related validation tests.
tests/meson.build	Add MTL include path; link mtl_tx.c into session_manager test.
src/util/config_reader.c	Implement multi-interface parsing, tx_video parsing, scaling validation, and dynamic config memory management.
src/mtl/mtl_tx.c	Extend MTL init to register multiple ports and route sessions by nic_index.
src/main.c	Log NIC[0] info when present; free app context on cleanup.
src/ffmpeg/ffmpeg_tx.c	Route FFmpeg mtl_st20p options via per-session NIC; add “first session registers 2nd NIC” workaround.
src/ffmpeg/ffmpeg_decoder.c	Decode/scale to “effective” dimensions when scaling is configured.
src/core/session_manager.c	Use scaled effective dimensions for fallback cropping; always call mtl_tx_uninit.
README.md	Document scaling feature and update config field descriptions (needs schema alignment).
meson.build	Make MTL a required dependency and add hardcoded MTL include path.
include/util/config_reader.h	Change config structs to dynamic arrays; add nic_index and dvledtx_config_free.
include/mtl/mtl_tx.h	Make mtl_tx_init/uninit always available; gate other APIs behind ENABLE_MTL_TX.
include/core/session_manager.h	Always include MTL API; make mtl_handle always part of session_manager.
include/app_context.h	Replace fixed session array with dynamically allocated NIC/session arrays and helpers.
config/tx_fullhd_single_session.json	Update sample config to new video + tx_video schema.
config/tx_fullhd_multi_session.json	Update sample config to new schema and adjusted values.
config/tx_fullhd_multi_nic.json	Add new multi-NIC example using per-session nic_index.
config/tx_4k_single_session.json	Update sample config to new schema and scaled output example.
config/tx_4k_multi_session.json	Update sample config to new schema and scaled tiled crops.
config/tx_2k_single_session.json	Update sample config to new schema.
config/tx_2k_multi_session.json	Update sample config to new schema.
.gitignore	Ignore generated dvledtx.log.

Comments suppressed due to low confidence (1)

tests/meson.build:32

• The test build hardcodes '/usr/local/include/mtl' in include_directories(), but mtl_dep is declared required:false. Since test_session_manager compiles ../src/mtl/mtl_tx.c, the suite will still fail to compile/link when MTL isn’t installed. Either gate MTL-dependent tests on mtl_dep.found() or make MTL required for tests.

test_inc    = include_directories('../include', '/usr/local/include/mtl')
test_deps   = all_deps + [cmocka_dep]
test_c_args = ['-DALLOW_EXPERIMENTAL_API']

test_config_reader = executable('test_config_reader',

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.