Add duration to utterance_start message - #146
Conversation
📝 WalkthroughWalkthroughImports a sound-duration helper and computes the duration of each played audio (stripping a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #146 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 8 8
Lines 1013 1018 +5
=====================================
- Misses 1013 1018 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@ovos_audio/playback.py`:
- Around line 134-136: Wrap the call to get_sound_duration in a local try/except
so a failure there doesn't abort playback: catch exceptions around
get_sound_duration(data.replace('file://', '')), set
message.data["duration"]=None on error (or leave unset), optionally log the
exception, and then continue to emit
self.bus.emit(message.forward("recognizer_loop:utterance_start", message.data))
and call play_audio as before; this change should be made inside the _play
method around the get_sound_duration usage to ensure playback proceeds even if
duration computation fails.
|
@femelo can you please rebase so the new CI bot and tests run? |
Add duration to utterance_start message
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.