feat(audio): add mute system output during dictation#511
Open
NathanSkene wants to merge 2 commits intoOpenWhispr:mainfrom
Open
feat(audio): add mute system output during dictation#511NathanSkene wants to merge 2 commits intoOpenWhispr:mainfrom
NathanSkene wants to merge 2 commits intoOpenWhispr:mainfrom
Conversation
| } | ||
|
|
||
| _buildMacUiMenuScript(appName, labels) { | ||
| const appleScriptList = labels.map((label) => `"${label.replace(/"/g, '\\"')}"`).join(", "); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
|
|
||
| _buildMacUiMenuScript(appName, labels) { | ||
| const appleScriptList = labels.map((label) => `"${label.replace(/"/g, '\\"')}"`).join(", "); | ||
| const escapedAppName = appName.replace(/"/g, '\\"'); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Contributor
Author
|
Validation update from local macOS testing:
The installed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mute system output while recordingoption alongside the existingPause mediasettingWhy
The existing
Pause mediafeature works well for supported players like Spotify, but unsupported apps such as Brain.fm desktop do not reliably expose a pause/resume control path. This new option directly solves the underlying recording-quality problem by silencing computer audio during dictation regardless of which app is producing it.Closes #510
Test plan
Mute system output while recordingin settings