argo: Return EISCONN when already bound#17
Open
jandryuk wants to merge 1 commit intoOpenXT:masterfrom
Open
Conversation
Calling bind multiple times would leak rings. Return -EISCONN for that case. Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
crogers1
approved these changes
Oct 19, 2021
Contributor
|
LGTM |
dpsmith
approved these changes
Oct 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling bind multiple times would leak rings. Return -EISCONN for that
case.
Signed-off-by: Jason Andryuk jandryuk@gmail.com
I've run with this for about a month without issue.
The other option would be to automatically clean up the old ring and continue with the bind. But doing things silently is not necessarily the best. I haven't seen anything fail with EISCONN, and applications that break from EISCONN should just be fixed.