Introduce KERNEL_MODULE_OFFLINE_SIGNING#1406
Merged
eric-ch merged 1 commit intoOpenXT:masterfrom Jun 10, 2021
Merged
Conversation
Introduce KERNEL_MODULE_OFFLINE_SIGNING to force the user to make an explicit choice to perform offline signing. Silently creating un-bootable images isn't user friendly. This variable forces them to make the choice. Add various checks for invalid configurations to enforce using the variable. Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Contributor
Contributor
eric-ch
approved these changes
Jun 9, 2021
Contributor
|
Will merge soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came about because reviewing PRs #1395 and #1401 illustrated the fragility of the offline signing support.
Introduce KERNEL_MODULE_OFFLINE_SIGNING to force the user to make an
explicit choice to perform offline signing. Silently creating
un-bootable images isn't user friendly. This variable forces them to
make the choice.
Add various checks for invalid configurations to enforce using the
variable.