Feature/bklit#379
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (79)
📝 WalkthroughWalkthroughMigrates charts to a VisX-based system with new contexts, shell, tooltip, series components, and overlays. Refactors overview widgets to these primitives. Adds referrer spikes backend service and TRPC route. Updates dependencies, CSS tokens, and icons. ChangesVisX charting, overview refactor, and referrer spikes
Sequence Diagram(s)sequenceDiagram
rect rgba(66, 135, 245, 0.5)
participant OverviewClient
participant TRPC as TRPC overview.getReferrerSpikes
participant DBService as getReferrerSpikes
end
OverviewClient->>TRPC: query(projectId, filters, interval, tz)
TRPC->>DBService: getReferrerSpikes(input)
DBService->>DBService: ClickHouse queries and scoring
DBService-->>TRPC: ReferrerSpikeCluster[]
TRPC-->>OverviewClient: clusters (formatted dates)
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements