Implement memory regions iterators#104
Open
moojek wants to merge 12 commits intoOperacja-System:mainfrom
Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
qbojj
requested changes
May 3, 2026
Comment on lines
+239
to
+242
| fdt_t fdt; | ||
| error_t err = hal_riscv_init_fdt(&fdt); | ||
| if (err) | ||
| return err; |
Collaborator
There was a problem hiding this comment.
I don't think I like reinitializing the fdt on every step
Contributor
Author
There was a problem hiding this comment.
I added file-level static fdt variable, is it a correct approach?
Co-authored-by: Copilot <copilot@github.com>
Kamilosok
requested changes
May 5, 2026
Collaborator
Kamilosok
left a comment
Kamilosok
left a comment
There was a problem hiding this comment.
The dt logic looks fine, didn't find anything wrong with memory stuff at a glance, though requesting a review from @frogrammer9 on this is a good idea. Noticed a few consistency issues.
|
|
||
| dt_prop_t address_cells_prop; | ||
| error_t err = dt_get_prop_by_name(fdt, node, "#address-cells", &address_cells_prop); | ||
| if (err == ERR_NONE) { |
Collaborator
There was a problem hiding this comment.
I prefer maintaining a logic flow where errors are handled first, and normal execution continues afterward, like other dt_ functions
|
|
||
| error_t err = dt_get_node_sibling(fdt, node, &node); | ||
| error_t err; | ||
| if (node != 0) |
Collaborator
There was a problem hiding this comment.
When doing special behavior like this document it well
|
|
||
| typedef struct { | ||
| u32 idx; | ||
| u32 memreserve_idx; |
| u64 size; | ||
| err = hal_riscv_read_reg_entry(fdt, next_iter.resmem_current_node, next_iter.resmem_reg_idx, | ||
| next_iter.resmem_address_cells, next_iter.resmem_size_cells, &addr, &size); | ||
| if (err == ERR_NONE) { |
Collaborator
There was a problem hiding this comment.
Same with error handling flow here
| u64 addr; | ||
| u64 size; | ||
| err = hal_riscv_read_reg_entry(fdt, next_iter.node, next_iter.reg_idx, address_cells, size_cells, &addr, &size); | ||
| if (err == ERR_NONE) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.