Skip to content

Added "Add" and "Subtract" to the arithmethic options. #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Lector wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Draft

Added "Add" and "Subtract" to the arithmethic options. #157

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8afbc75
Added "Add" and "Subtract" to the arithmethic options.
Lector Jun 10, 2026
755b559
Changed minimum of arithmethic to 1
Lector Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/types/_ActivatableSkillCheckResultBased.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ const CheckResultArithmetic = DB.Enum(import.meta.url, {
name: "CheckResultArithmetic",
comment: "Defines how the the `value` is set off against the check result.",
values: () => ({
Add: DB.EnumCase({ type: null }),
Subtract: DB.EnumCase({ type: null }),
Multiply: DB.EnumCase({ type: null }),
Divide: DB.EnumCase({ type: null }),
}),
Expand All @@ -29,7 +31,7 @@ export const CheckResultBasedModifier = DB.TypeAlias(import.meta.url, {
}),
value: DB.Required({
comment: "The value that is applied to the `base` using the defined `arithmetic`.",
type: DB.Integer({ minimum: 2 }),
type: DB.Integer({ minimum: 1 }),
}),
}),
})
Expand Down
Loading