Added Active as a usage type to CombatStyle#171
Open
Lector wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
Bei mir lokal kommt noch ein Fehler bei IdentifierGroup.ts. Ich kann aber nicht nachvollziehen wie es dazu kommt. |
elyukai
reviewed
Jun 23, 2026
| "Aspect": null, | ||
| "As chosen": null, | ||
| "Passive": null, | ||
| "Active": null, |
elyukai
reviewed
Jun 23, 2026
elyukai
left a comment
elyukai
left a comment
Member
There was a problem hiding this comment.
Ich hätte den Namen usage_type einfach in beiden Fällen belassen. Gibt es einen Grund, warum du die Namen verändert hast bzw. unterschiedlich gemacht hast?
Collaborator
Author
|
dann hätte wir in einer Datei 2 Mal usage_type ... da hätte ich jetzt einen Fehler erwartet. Wenn wir den usage_type von CombatSA und CombatStyle aufteilen müssen wir durch einen unterschiedlichen Namen doch zwischen denen unterscheiden können. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes /issues/170
Hier klappt noch irgendetwas nicht. Ich weis nicht wo der Fehler ist.