This repository was archived by the owner on Oct 20, 2022. It is now read-only.
SSL support for client-server communication using Thrift SSL socket.#72
Open
shobhit85 wants to merge 5 commits into
Open
SSL support for client-server communication using Thrift SSL socket.#72shobhit85 wants to merge 5 commits into
shobhit85 wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the change which provides capability for a php client to communicate to a Cassandra server over SSL, by setting certain SSL properties in PDO constructor in the php code. Check changes in tests/config.inc-dist for more information.
Same test suit was used to test this implementation, by just one minor modification in all tests i.e. by adding "params" parameter to PDO constructor and then for SSL based tests, adding new properties to the params array.
All tests with the implementation pass if Cassandra server is configured correctly with key/cert in keystore/truststore. Please refer to wikipage-edit.txt for more details.
Note: If the changes don't compile with Thrift 0.9.1, try using next release version 0.9.2.