This repository was archived by the owner on Oct 20, 2022. It is now read-only.
Closed
Conversation
Fixed arguments array passed to the registered rpc
Fixed array passed to the function
Passing session to the RPC function
Passing Session to the RPC function
exposed wsclient
|
This does not look correct to me. I don't think there was a problem with the existing implementation. |
Author
|
Sorry! Some other commits were added in the pull request by mistake. The functions registered on regrpc will always receive 2 parameters: 1ID and 1 array of arguments sent by the caller. Is that correct? Is that the expected? If the caller sends argument: 1, 2, 3 Inside the change that I did, each argument sent by the caller would became a parameter on the handler registered |
|
There are problems with the regrpc/resrpc implementation I think. See #11 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix is related to the function that is being called in the server.
Instead of receive the arguments on its position, it was receiving 2 argument, invId and the array of the array of arguments passed by the clients.
Yes, one array inside the other