Skip to content

Add JavaScript extensions#264

Open
rderooij wants to merge 2 commits intoOrderOfTheBee:masterfrom
rderooij:feature/jscript-extensions
Open

Add JavaScript extensions#264
rderooij wants to merge 2 commits intoOrderOfTheBee:masterfrom
rderooij:feature/jscript-extensions

Conversation

@rderooij
Copy link

Integrated the Alfresco JavaScript Extensions (from alfresco-jscript-extensions by jgoldhammer) into OOTBee Support Tools. This PR adds several new root objects to the JavaScript API.

@AFaust
Copy link
Contributor

AFaust commented Mar 6, 2026

@rderooij Sorry for not getting back to you earlier on this PR. First of all, thanks for the suggestion to integrate a fork of that extension into the OOTBee Support Tools. Since I personally have never used that addon (it adds functionality I found potentially problematic or going beyond what I thought "should" be made available), I am not that familiar with its current compability state.
What is your rationale for suggesting this integration? I see the original project is still available on GitHub, though it hasn't had a new commit in 4 years. It can be installed separately alongside the OOTBee Support Tools to add the script root objects, without necessarily having to integrate it into this project. Is there a compatibility issue with specific (newer) ACS versions that won't get fixed in the upstream project (anymore)? Do you foresee the space for other improvements that won't find a place in the original project, maybe because the maintainer is non-responsive/unavailable?
I am open to merging this integration if the original project is "dead" and this is the only means to keep the functionality available for the community. I may want to add configurable enablement flags for specific root objects in the future to control those I don't want to have (easily) available. There is certainly an argument to be made that even without these root objects, problematic API is available via reflection / Spring context access - my personal preference is just to not make certain dangerous features "too easy to use" that may lead up to some admin shooting themselves in the foot.

In case we go ahead (the original project is dead), could I ask you to apply the common code style used in this project to your contribution? Alternatively, if you were to allow reviewers to push changes to your PR branch, I could apply the code style and additional cleanup (removing commented code, logging and/or config improvements, ...) before doing the actual merge.

@rderooij
Copy link
Author

I have updated the code based on the style guide.

The original project latest release was in 2017. There is a 1.8 release from 2021 in Maven, but it is no longer compatible with recent versions of ACS. The rationale in my view is that jconsole is part of OOTBee, so why not make jconsole more useful with some extra root objects.

I did not try to create a pull request to the original creator. I could try that first to validate whether the project is 'dead'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants