fix(speech): stop speech with Control in menus and help reader#26
Merged
Conversation
Left or Right Control silenced only the driving event voice. Menus and the how-to-play reader speak on the main channel, so a long readout (job details, cargo loading, a full help page) could not be cut short. Add a GameContext stop_speech() that quiets both channels, wire Control to it in the menu base class and the help reader, document the key, and cover it with tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Left or Right Control already stopped the driving event voice, but menus and the how-to-play reader speak on the main channel, so pressing Control there did nothing. A long readout -- job details, cargo loading, a full help page -- could not be cut short.
This adds
GameContext.stop_speech()(silences both channels) and wires Control to it in the sharedMenuStatebase class and theHelpStatereader, so the same key now stops speech everywhere in the game.What players/maintainers will notice
Tests / checks run
tests/test_menu_stop_speech.pycovers the menu key, the help-reader key, and thatstop_speech()quiets both channels.uv run pytest(focused: menu/controls/speech/driving suites),uv run ruff check src tests tools,uv run python -m compileall src tests tools-- all pass. pre-commit hooks pass.Accessibility impact
Directly improves screen-reader UX: a verbose menu readout (e.g. the cargo loading screen) can now be silenced instantly with a familiar key, instead of forcing the player to wait it out. No visual-only cues introduced; spoken behavior only.
🤖 Generated with Claude Code