Skip to content

[misc] test: prune obsolete tests#249

Merged
JoyboyBrian merged 1 commit into
mainfrom
brian/prune-obsolete-tests
Jul 2, 2026
Merged

[misc] test: prune obsolete tests#249
JoyboyBrian merged 1 commit into
mainfrom
brian/prune-obsolete-tests

Conversation

@JoyboyBrian

@JoyboyBrian JoyboyBrian commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

What

  • Remove obsolete tests for deleted CLI commands, removed API/model symbols, migration-era absence checks, and redundant private fallback behavior.
  • Delete the unused tests/golden/cli_output/workspace_serializer.json fixture and tests/unit/cli/test_init_json.py.
  • Keep current legacy credential/config coverage where production code still supports those paths.
  • Exclude root-level gitignored CLAUDE.md and AGENTS.md from markdown link scanning.

Why

This trims tests that only preserve old behavior after feature/API removal, reducing maintenance noise while keeping coverage for current compatibility commitments. The docs link scanner change prevents local ignored agent guidance files from making full test runs fail on this machine.

How to Test

  • uv run --extra dev ruff check .
  • uv run --extra dev ruff format --check .
  • uv run --extra dev pyright osmosis_ai/
  • uv run --extra dev python -m pytest

Checklist

  • PR title follows [module] type: description format
  • Appropriate labels added (repo has no test or misc label; this update is scoped to title/body)
  • ruff check . and ruff format --check . pass
  • pyright osmosis_ai/ passes
  • pytest passes (new tests added if applicable)
  • Public API changes are documented (N/A, no public API changes)
  • No secrets or credentials included

Summary by cubic

Pruned obsolete tests tied to removed CLI commands and deprecated API/model symbols to reduce maintenance. Also excluded root-level CLAUDE.md and AGENTS.md from the docs link scanner so local files don’t affect test results.

  • Refactors

    • Removed tests for deleted commands/symbols and migration-era absence checks; deleted unused golden tests/golden/cli_output/workspace_serializer.json and tests/unit/cli/test_init_json.py.
    • Kept compatibility tests where legacy credential/config paths remain supported.
  • Bug Fixes

    • Docs link scanner now ignores root-level CLAUDE.md and AGENTS.md.

Written for commit f7581e1. Summary will update on new commits.

Review in cubic

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@JoyboyBrian JoyboyBrian changed the title [codex] Prune obsolete tests [misc] test: prune obsolete tests Jul 2, 2026
@github-actions github-actions Bot added the chore Maintenance/chores label Jul 2, 2026
@JoyboyBrian JoyboyBrian marked this pull request as ready for review July 2, 2026 17:47
@JoyboyBrian JoyboyBrian requested a review from BaiqingL as a code owner July 2, 2026 17:47

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 18 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@JoyboyBrian JoyboyBrian merged commit fa21d47 into main Jul 2, 2026
12 of 14 checks passed
@JoyboyBrian JoyboyBrian deleted the brian/prune-obsolete-tests branch July 2, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance/chores

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant