This repository was archived by the owner on Jun 24, 2022. It is now read-only.
Secret customization#285
Open
koushyk wants to merge 2 commits intoOteemo:masterfrom
koushyk:secret-customization
Open
Secret customization#285koushyk wants to merge 2 commits intoOteemo:masterfrom koushyk:secret-customization
koushyk wants to merge 2 commits intoOteemo:masterfrom
koushyk:secret-customization
Conversation
rjkernick
suggested changes
May 24, 2021
Contributor
rjkernick
left a comment
rjkernick
left a comment
There was a problem hiding this comment.
A few other items would need changed in the chart in order for this to work properly. The version in chart.yaml would also need changed
| kind: Secret | ||
| metadata: | ||
| name: {{ template "nexus.name" . }}-secret | ||
| name: {{ toYaml .Values.secret.metadata.name }} |
Contributor
There was a problem hiding this comment.
This would need changed in the places that use the secret as well. I recommend adding something to the helpers.tpl and ensuring that all references that use the secret use the function you create in the helpers.tpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added possibility to change type of secret and its name