Merged
Conversation
Move the `std::vector` restriction into an `enable_if` clause. Use member type definitions instead of template arguments.
Guard against the container itself being trivial to avoid ambiguous calls. This excludes `std::array`, which is served by the other method taking trivial types. A trivial container of trivial types is itself trivial. Note: Technically, this should guard for types with `.data()` and `.size()` members. Such members imply a contiguous container.
This is now served by the more general non-trivial contiguous container of trivial types case.
Move the `std::vector` restriction into an `enable_if` clause. Use member type definitions instead of template arguments.
It doesn't really need to exist, and eliminating it makes the implementation match the size prefixed string write method.
This can potentially handle the size prefix part of any container write, including containers we don't yet support serialization for. Currently we simply delegate for the details of writing the actual container contents.
This is now served by the more general size prefixed container write case.
Brett208
approved these changes
Apr 19, 2019
Member
Brett208
left a comment
Brett208
left a comment
There was a problem hiding this comment.
Seems to compile and work fine. Tried with OP2Archive and it worked. I keep glazing over when trying to understand the significance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates for Write stream method guards.
This consolidates the
std::vectorandstd::stringvariants of the write methods into unified container write methods. The differences were little more than variable names, and the overload type.This relates to Issue #278. This simplifies template parameters, which may help PR #281.
Corresponding updates should be made to the Read stream method guards. (Added in PR #288).
The existing unit tests helped with the development of this. Particularly after I changed the meaning of a template
Tparameter, but forgot to update a correspondingsizeof(T). Nevertheless, I find myself thinking a few additional unit tests might be good, which runs through various categories of types, doing a quick round trip serialization on them.