-
Notifications
You must be signed in to change notification settings - Fork 5
Implements Seed Checker #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems reasonable.
Only thing that I'm unsure about: ensure we run the safetychecker before giving the image to the WM, if you aren't already; you don't want someone to modify the safety cache or swap in an image after it's already been checked. You can keep an in-memory cache for seeds (by hash?) to make this a bit less painful for revisiting the same seed.
Oh, and fix the CI, but that's a given
|
Note to self before merge: disable W8A8 quant, we're not supposed to run the model with a quant |
|
Fixes #19 |
Fixes #15 and #10.
Implements nsfw seed checker with https://huggingface.co/Freepik/nsfw_image_detector.
Also includes a restructure to server-components to run as a single unified server on port 7987: server.py (bridge), world_engine.py (generation), safety.py (NSFW detection)
Previous implementation was some hybrid client-server setup that had client managing the seed directory. The new implementation now allocates seed directory, safety checking and seed image integrity verification on server side. Having the safety checks be performed server side also ensures that if the server is hosted on separate device as the client, the safeties and generations are still authorised by the server process.
Current behaviour is that unsafe files hidden from UI (not deleted) and warns user about hidden files.