Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR moves explorer launcher logic out of shared bash (scripts/common.sh) into a reusable, unit-tested Python module (src/ananta/explorers/launcher.py), while keeping minimal bash shims for venv + dependency bootstrapping.
Changes:
- Added a shared Python launcher (
LauncherConfig, preflight checks, frontend build, and process launch) plus unit tests. - Rewrote explorer
*.shscripts into thin venv-bootstrap shims that delegate to per-explorerlaunch.py. - Removed obsolete shell-based launcher code (
scripts/common.sh,examples/arxiv-explorer.sh) and the BATS test suite.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| TODO.md | Removes completed TODOs related to rewriting shell scripts in Python. |
| tests/unit/explorers/test_launcher.py | Adds unit coverage for Python launcher behaviors (arg parsing, preflight, frontend build, launch). |
| tests/scripts/test_common.bats | Deletes BATS tests tied to the removed scripts/common.sh. |
| src/ananta/explorers/launcher.py | Introduces the shared Python launcher implementation. |
| scripts/common.sh | Deletes the old shared bash launcher logic. |
| README.md | Updates Document Explorer docs to use the new launcher shim and removes “Experimental” labeling. |
| paad/code-reviews/ovid-explorer-launchers-to-python-2026-03-22-15-32-48-2a8e57f.md | Adds/updates an internal agentic review artifact for the branch. |
| examples/arxiv-explorer.sh | Removes the stale arXiv example launcher script. |
| document-explorer/launch.py | Adds per-explorer config entrypoint delegating to the shared launcher. |
| document-explorer/document-explorer.sh | Converts to thin venv-bootstrap shim that execs launch.py. |
| docs/plans/2026-03-22-python-launcher-implementation.md | Adds the implementation plan doc for the Python launcher migration. |
| docs/plans/2026-03-22-python-launcher-design.md | Adds the design doc describing the new launcher architecture. |
| code-explorer/launch.py | Adds per-explorer config entrypoint delegating to the shared launcher. |
| code-explorer/code-explorer.sh | Converts to thin venv-bootstrap shim that execs launch.py. |
| CHANGELOG.md | Documents the launcher rewrite and removal of old shell launch artifacts. |
| arxiv-explorer/README.md | Updates arXiv explorer instructions to reference the new shim path. |
| arxiv-explorer/launch.py | Adds per-explorer config entrypoint delegating to the shared launcher. |
| arxiv-explorer/arxiv-explorer.sh | Converts to thin venv-bootstrap shim that execs launch.py. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move explorer launchers from shell scripts to Python.