ci: drop dead golint step, align Go to go.mod 1.25, bump checkout to v4 - #228
Open
Bonny07 wants to merge 1 commit into
Open
ci: drop dead golint step, align Go to go.mod 1.25, bump checkout to v4#228Bonny07 wants to merge 1 commit into
Bonny07 wants to merge 1 commit into
Conversation
ci.yaml installed golang.org/x/lint/golint but never invoked it; golint has been deprecated and frozen since 2021. The CI Go version (1.24.2) also lagged the go.mod directive (1.25). Remove the dead step, align both workflows to Go 1.25, and bump the remaining actions/checkout@v3 usages to v4 (release.yaml was already on v4).
Collaborator
Author
|
Gentle bump on this — it's CI-only (drops the archived Related: I opened #229 adding a hermetic unit-test suite for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A few CI housekeeping fixes:
ci.yamlinstalledgolang.org/x/lint/golintbut never invoked it, and golint has been deprecated/frozen since 2021.1.24.2whilego.modand the Dockerfile are on1.25; bump them to1.25.actions/checkout@v3tov4inci.yamlanddocker.yaml(release.yamlwas already on v4), off the deprecated Node 16 runtime.Test