Conversation
…gging directly into core modules
Bundles the in-progress 1.0.0b4 work as a baseline: - Bump version to 1.0.0b4 in pyproject.toml. - Refactor exception handling across DfttTimecode and DfttTimeRange: raise DFTTError subclasses with descriptive messages instead of raising bare exception classes followed by separate logger.error calls. - Stop the silent SMPTE fallback in DfttTimecode.timecode_output() for unexpected conversion errors; only the defensive AttributeError guard remains. - Narrow exception wrapping in DfttTimeRange.offset / .extend / .__contains__ to wrap only DFTTError raised during internal DfttTimecode construction; other exception types now propagate. - Document all of the above in CHANGELOG.md under [1.0.0b4]. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…remove class-level state defaults
- Simplified error message formatting in DfttTimeRange class to single-line raises. - Updated assertions in test cases to use more concise boolean expressions. - Added configuration for Ruff and Ty to pyproject.toml for linting and type checking.
OwenYou
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.0.0B4