Add mob count modifier for quests. Adjust static final DIRECTORY so t…#331
Open
jimmyhong94 wants to merge 1 commit intoP0nk:masterfrom
Open
Add mob count modifier for quests. Adjust static final DIRECTORY so t…#331jimmyhong94 wants to merge 1 commit intoP0nk:masterfrom
jimmyhong94 wants to merge 1 commit intoP0nk:masterfrom
Conversation
…ests run in isolation Adjusted test code Add QUEST_MOB_COUNT_MODIFIER for quest requiring monster kills Added description to new config QUEST_MOB_COUNT_MODIFIER variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ests run successfully
Description
On quests where a monster count is required for completion (99 / 999 quests, etc) a new config variable can be set to increase the amount 1 monster counts toward the quest requirement. Defaulted to 1 like normal and any integer is valid (10000 can be used, quest limit is maximum).
I chose to let negative values be valid as well since it's unlikely a user will ever do this unintentionally so, didn't add code to prevent this.
I made modifications to the DIRECTORY variable in WZfiles.java because it was caching with my new test class inappropriately (Quest in my test class cached DIRECTORY for subsequent tests). In isolation, these tests they ran successfully. In unison, the failed without my changes. All tests now run successfully with my changes.
Checklist before requesting a review
Screenshots
Spawned 10 evil eyes for quest with a 5 used for the new modifier. Got 50 added to quest requirement on !killall used on the 10.
Item counts unaffected (only kill counts)
-1 used for this example successfully:
