chore: remove E2E tests in favor of unit and integration tests#22
Merged
chore: remove E2E tests in favor of unit and integration tests#22
Conversation
In Playwright, timing() is a method on the Request object, not the Response object. This was causing all E2E tests to fail with "TypeError: res.timing is not a function". Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The E2E tests provided marginal value: - Mostly redundant with existing unit tests (useSession, useWebSocket, etc.) - Slow (37 min) and flaky due to timing dependencies - Backend perf tests already cover real HTTP/WS integration - No unique coverage that unit/integration tests don't already provide This removes: - web/e2e/ directory (all Playwright test files) - web/playwright.config.ts - E2E-related scripts from package.json - @playwright/test dependency - e2e-tests job from CI workflow Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
PABannier
changed the title
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSession.test.ts(26 tests)useWebSocket.test.ts(14 tests)usePresence.test.ts(14 tests)bench_smoke,bench_standard)What was removed
web/e2e/directory (all Playwright test files)web/playwright.config.tspackage.json@playwright/testdependencye2e-testsjob from CI workflowImpact
🤖 Generated with Claude Code