docs+tests: locale Upgrading sections + flaky vector-supplement test fixes#52
Merged
Conversation
…plement tests
Docs
- Add ## Upgrading section to 9 locale READMEs (zh-TW, zh-CN, ja, ko, de,
fr, es, pt, vi). English + Thai already had it after v4.2.5; the other
9 were missing the upgrade flow + pre-v4.2.5 fallback note. All 11
locales now have matching 17 ## headings.
- Add a > [!IMPORTANT] "actively developed project" callout immediately
after the hero divider in every README, routing users to GitHub Issues
for bug reports / feature requests.
Tests
- http.test.ts recall-empty: assertion was toHaveLength(0) but
recallEnhanced may legitimately supplement FTS5 misses with sqlite-vec
near-neighbours when ONNX embeddings are loaded. Asserts the API
contract (valid JSON array, bounded length, entity-shaped rows) instead.
- tools.test.ts auto-archive: same root cause — recall('JWT') after
archiving auth-v2 asserted []. Behavioural guarantee is "archived rows
hidden", so asserts not.toContain('auth-v2') and accepts vector
supplement surfacing related auth-v3.
- pre-bash-orchestration-nudge.test.ts: the "default off" test failed on
developer machines where ~/.memesh/config.json sets
enableAgenticOrchestration: true. Both the test helper and the gate-off
case now pin MEMESH_DIR to the per-test tmpdir so readHookConfig() can
no longer read the developer's real config.
All 65 test files / 1045 tests pass.
Multi-Model SynthesisBoth Claude and Codex reviews above are independent. The most Reviewer responsibility: read both, surface non-overlapping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-v4.2.7 cleanup that closes the two follow-ups noted in the v4.2.7 CHANGELOG.
Docs
## Upgradingsection. EN + TH had it after v4.2.5; the other 9 (zh-TW, zh-CN, ja, ko, de, fr, es, pt, vi) were missing the section entirely. Heading parity across all locales is now 17/17.> [!IMPORTANT]"actively developed project" callout immediately after the hero divider, linking to GitHub Issues. Sets expectations that features evolve between releases and routes bug reports / feature requests to the right channel from the first glance.Tests
Three flakes/environment-leaks fixed:
tests/transports/http.test.ts > returns array (possibly empty) for no-match query— assertedtoHaveLength(0), butrecallEnhancedmay supplement FTS5 misses with sqlite-vec near-neighbours when ONNX embeddings are loaded. New assertion mirrors the actual API contract (valid JSON array, bounded length, entity-shaped rows).tests/tools.test.ts > auto-archives entity when superseded by new remember— same root cause;recall('JWT')after archivingauth-v2asserted exactly[]. Behavioural guarantee is "archived rows stay hidden", so the assertion now checksnot.toContain('auth-v2')instead of strict empty-array.tests/hooks/pre-bash-orchestration-nudge.test.ts > emits nothing when MEMESH_ENABLE_AGENTIC_ORCHESTRATION is unset— the "default off" test deleted the env var but didn't pinMEMESH_DIR. On a developer machine withenableAgenticOrchestration: truein~/.memesh/config.json,readHookConfig()reopened the gate and the test failed. Both the test helper and the gate-off case now pointMEMESH_DIRat the per-test tmpdir.Doc-sync checklist
[Unreleased]section)Test plan
npm test -- --run tests/transports/http.test.ts tests/tools.test.ts tests/hooks/pre-bash-orchestration-nudge.test.ts— 83/83 passnpm test -- --run(full suite) — 65 files / 1045 tests pass