Skip to content

docs+tests: locale Upgrading sections + flaky vector-supplement test fixes#52

Merged
kevintseng merged 1 commit into
mainfrom
chore/post-v4.2.7-cleanup
May 13, 2026
Merged

docs+tests: locale Upgrading sections + flaky vector-supplement test fixes#52
kevintseng merged 1 commit into
mainfrom
chore/post-v4.2.7-cleanup

Conversation

@kevintseng
Copy link
Copy Markdown
Contributor

Summary

Post-v4.2.7 cleanup that closes the two follow-ups noted in the v4.2.7 CHANGELOG.

Docs

  • All 11 README locales now have an ## Upgrading section. EN + TH had it after v4.2.5; the other 9 (zh-TW, zh-CN, ja, ko, de, fr, es, pt, vi) were missing the section entirely. Heading parity across all locales is now 17/17.
  • Every README gets a > [!IMPORTANT] "actively developed project" callout immediately after the hero divider, linking to GitHub Issues. Sets expectations that features evolve between releases and routes bug reports / feature requests to the right channel from the first glance.

Tests

Three flakes/environment-leaks fixed:

  1. tests/transports/http.test.ts > returns array (possibly empty) for no-match query — asserted toHaveLength(0), but recallEnhanced may supplement FTS5 misses with sqlite-vec near-neighbours when ONNX embeddings are loaded. New assertion mirrors the actual API contract (valid JSON array, bounded length, entity-shaped rows).
  2. tests/tools.test.ts > auto-archives entity when superseded by new remember — same root cause; recall('JWT') after archiving auth-v2 asserted exactly []. Behavioural guarantee is "archived rows stay hidden", so the assertion now checks not.toContain('auth-v2') instead of strict empty-array.
  3. tests/hooks/pre-bash-orchestration-nudge.test.ts > emits nothing when MEMESH_ENABLE_AGENTIC_ORCHESTRATION is unset — the "default off" test deleted the env var but didn't pin MEMESH_DIR. On a developer machine with enableAgenticOrchestration: true in ~/.memesh/config.json, readHookConfig() reopened the gate and the test failed. Both the test helper and the gate-off case now point MEMESH_DIR at the per-test tmpdir.

Doc-sync checklist

  • CHANGELOG.md updated (new [Unreleased] section)
  • README.md + 10 locale READMEs synced (heading count: 17 across all)
  • docs/ARCHITECTURE.md — no module/structure changes
  • docs/api/API_REFERENCE.md — no public-surface changes
  • CLAUDE.md — no project-structure changes
  • Version files — not bumping; this is doc + test cleanup only
  • dist/skills-manifest.json — no skills/hooks/plugin file changes

Test plan

  • npm test -- --run tests/transports/http.test.ts tests/tools.test.ts tests/hooks/pre-bash-orchestration-nudge.test.ts — 83/83 pass
  • npm test -- --run (full suite) — 65 files / 1045 tests pass
  • Reviewer: verify CI is green before merge

…plement tests

Docs
- Add ## Upgrading section to 9 locale READMEs (zh-TW, zh-CN, ja, ko, de,
  fr, es, pt, vi). English + Thai already had it after v4.2.5; the other
  9 were missing the upgrade flow + pre-v4.2.5 fallback note. All 11
  locales now have matching 17 ## headings.
- Add a > [!IMPORTANT] "actively developed project" callout immediately
  after the hero divider in every README, routing users to GitHub Issues
  for bug reports / feature requests.

Tests
- http.test.ts recall-empty: assertion was toHaveLength(0) but
  recallEnhanced may legitimately supplement FTS5 misses with sqlite-vec
  near-neighbours when ONNX embeddings are loaded. Asserts the API
  contract (valid JSON array, bounded length, entity-shaped rows) instead.
- tools.test.ts auto-archive: same root cause — recall('JWT') after
  archiving auth-v2 asserted []. Behavioural guarantee is "archived rows
  hidden", so asserts not.toContain('auth-v2') and accepts vector
  supplement surfacing related auth-v3.
- pre-bash-orchestration-nudge.test.ts: the "default off" test failed on
  developer machines where ~/.memesh/config.json sets
  enableAgenticOrchestration: true. Both the test helper and the gate-off
  case now pin MEMESH_DIR to the per-test tmpdir so readHookConfig() can
  no longer read the developer's real config.

All 65 test files / 1045 tests pass.
@github-actions
Copy link
Copy Markdown

Multi-Model Synthesis

Both Claude and Codex reviews above are independent. The most
valuable signals are the issues only ONE model raised
— those
are the blind spots single-model review misses.

Reviewer responsibility: read both, surface non-overlapping
findings, decide which need fixing before merge.

@kevintseng kevintseng merged commit f2c1d5f into main May 13, 2026
15 checks passed
@kevintseng kevintseng deleted the chore/post-v4.2.7-cleanup branch May 13, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant