Skip to content

minor corrections - whitespace and links#554

Merged
mohawk2 merged 4 commits intoPDLPorters:masterfrom
duffee:POD-Graphics-Internals
Apr 24, 2026
Merged

minor corrections - whitespace and links#554
mohawk2 merged 4 commits intoPDLPorters:masterfrom
duffee:POD-Graphics-Internals

Conversation

@duffee
Copy link
Copy Markdown
Contributor

@duffee duffee commented Apr 23, 2026

Also added comments highlighting TODOs in Indexing asking for more content.

(fixed irritating git config mistake to track upstream not origin )

I see that PDL::Index needs to be regenerated by utils/scantree.pl before the next release to pick of the move of PDL::MATLAB to PDL::Guides::Migration::MATLAB. I tried on my machine, but got errors and when I did produce an Index.pod, I saw some parsing errors that I couldn't determine the cause of, like this diff fragment

-L<PDL::Parallel::threads::SIMD> - launch and synchronize Single-Instruction-Multiple-Dataset code
+L<PDL::Parallel::threads::SIMD> - launch and synchronize
+

where it just truncates the item. It also includes way too many modules in the Index, so I'll pretend I didn't see that and move on. ;)

Added comments highlighting TODOs in Indexing asking for more content
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 23, 2026

Coverage Status

coverage: 70.07%. remained the same — duffee:POD-Graphics-Internals into PDLPorters:master

Copy link
Copy Markdown
Member

@mohawk2 mohawk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! Please could you make a couple of tweaks?

Comment thread lib/PDL/Graphics.pod
Comment thread lib/PDL/Graphics.pod Outdated
Comment thread lib/PDL/Indexing.pod Outdated
Comment thread lib/PDL/Indexing.pod Outdated
Comment thread lib/PDL/Internals.pod Outdated
Comment thread lib/PDL/InstallGuide.pod
Comment thread lib/PDL/Internals.pod Outdated
@mohawk2 mohawk2 merged commit a8e6867 into PDLPorters:master Apr 24, 2026
17 of 18 checks passed
@mohawk2
Copy link
Copy Markdown
Member

mohawk2 commented Apr 24, 2026

I've squashed this for tidiness, thank you for your diligent work in making things better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants