minor corrections - whitespace and links#554
Merged
mohawk2 merged 4 commits intoPDLPorters:masterfrom Apr 24, 2026
Merged
Conversation
Added comments highlighting TODOs in Indexing asking for more content
mohawk2
requested changes
Apr 23, 2026
Member
mohawk2
left a comment
There was a problem hiding this comment.
Thank you for this! Please could you make a couple of tweaks?
mohawk2
requested changes
Apr 24, 2026
mohawk2
reviewed
Apr 24, 2026
mohawk2
reviewed
Apr 24, 2026
Member
|
I've squashed this for tidiness, thank you for your diligent work in making things better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added comments highlighting TODOs in Indexing asking for more content.
(fixed irritating git config mistake to track
upstreamnotorigin)I see that PDL::Index needs to be regenerated by utils/scantree.pl before the next release to pick of the move of PDL::MATLAB to PDL::Guides::Migration::MATLAB. I tried on my machine, but got errors and when I did produce an Index.pod, I saw some parsing errors that I couldn't determine the cause of, like this diff fragment
where it just truncates the item. It also includes way too many modules in the Index, so I'll pretend I didn't see that and move on. ;)