Port: Add automatic support for Inputs to the VisualInstructionParameters - #648
Merged
1nf0rmagician merged 2 commits intoSep 30, 2025
Merged
Conversation
…ualinstructorparameter Add automatic support for Inputs to the VisualInstructionParameters (cherry picked from commit c3b0c091d46fe122072b0b7b3ab3ebc7b513b3d1)
The interface was only used in `VisualInstructionParameters` which can and is being used as a base class in most cases anyway. Hence IVisualInstructions is removed in favor of a more extendable base class.
1nf0rmagician
added
enhancement
1nf0rmagician
commented
Sep 26, 2025
1nf0rmagician
left a comment
1nf0rmagician
left a comment
Member
Author
There was a problem hiding this comment.
@dbeuchler FYI, the code has been cleaned up and the breaking change noted in the migration guide
dbeuchler
approved these changes
Sep 26, 2025
1nf0rmagician
deleted the
port/add-inputs-to-visualinstructorparameters
branch
September 30, 2025 05:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The interface was only used in
VisualInstructionParameterswhich can and is being used as a base class in most cases anyway.Hence IVisualInstructions is removed in favor of a more extendable base class.
Linked Issues
Ports: PHOENIXCONTACT/MORYX-Factory#117
Breaking Changes
IVisualInstructionswithVisualInstructionParametersChecklist for Submitter
Review
Typical tasks
Clean code