Added confirmation dialog to database delete action and changed layout#40
Open
VladPxC wants to merge 1 commit into
Open
Added confirmation dialog to database delete action and changed layout#40VladPxC wants to merge 1 commit into
VladPxC wants to merge 1 commit into
Conversation
To avoid accidentally pressing the button, I have moved the button group to the right.
|
|
Author
|
Just an additional note: I could not build after checking out the repository until I had "@types/react-router-dom": "^5.3.3" downgraded to "@types/react-router-dom": "^5.1.5" . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the maintanance, we have noticed that the delete button for deleting the entire database is located above the tab for executing the setup scripts. Since the delete button also has a prominent colour, people tend to click on it quickly and delete the database by mistake. This happened repeatedly to several team members during the development phase and would be fatal on a production system.
Therefore, an additional confirmation prompt was added and the buttons were moved to the right in the layout to gain a little distance.