Initial approach

[holtkamp]

No description provided.

[holtkamp]

@mnapoli what do you think of this approach? Is it viable, or would you advise differently?

[mnapoli]

Really sorry for the delay! That looks good, I have a few remarks I'll post them inline in the diff.

[mnapoli]

I think it's better to restrict to major versions to avoid being affected by a BC break in any of those packages.

Random example: the class Zend\Expressive\Container\ApplicationFactory could very well be removed in a new major version.

[holtkamp]

ok

[mnapoli]

Here is an idea: instead of requiring the containerBuilder.php file that is in vendor/ there could be instead a class, e.g. ExpressiveContainerBuilder, that extends from ContainerBuilder and auto-add the configuration files of this repository.

The advantage I see is it benefits from autoloading so it avoids the long line of include that goes looking in vendor/ (which is kind of unusual), and also the possibility to get rid of all the if(class_exists('Zend\Expressive\Router\AuraRouter')){ in the config files => the ExpressiveContainerBuilder could have methods dedicated to include configuration for libraries.

Here is an example of what it could look like:

// the $inProduction could be used to enable/disable Twig debug or other debug for example
$containerBuilder = new ExpressiveContainerBuilder($inProduction);
$containerBuilder->registerAuraRouter();
$containerBuilder->registerTwigRenderer();
// All methods of the container builder can still be used of course
$containerBuilder->addDefinitions(/* your own definition files */);

It's a bit less automatic than your current solution but relying on class_exists is risky IMO, it's not because a class is installed in vendor/ that you want to use it in your application. And that way it's much more explicit/easier to understand what's happening.

[holtkamp]

mm, seems better indeed, will have a look at this!

[mnapoli]

Inline code blocks are made with single quotes: "In your ./public/index.php"

[holtkamp]

thanks, did not know that...

[holtkamp]

@mnapoli adopted your suggestion to use a ExpressiveContainerBuilder class, works nice indeed!

Sole point of hesitation is the order of arguments in the constructor:

public function __construct($inProduction = false, $containerClass = 'DI\Container')

will become incompatible with the ContainerBuilder when using more strict types (PHP 7 will be enforced some day):

public function __construct(bool $inProduction = false, string $containerClass = 'DI\Container')