PHP 8.4 polyfill: update the ruleset for bc*() function / sync with v1.34.0#92
Merged
Merged
Conversation
…1.34.0 As of version v1.34.0, the BCMath `bcceil()`, `bcfloor()` and `bcround()` functions, as introduced in PHP 8.4, are now included in the Symfony polyfill. Note: the upstream commit also polyfills the PHP `RoundingMode` enum, however, PHPCompatibility doesn't detect this yet, so this will need to be dealt with at a later point in time once it becomes clear how PHPCompatibility will report on this. A test for the enum has been added to ensure that the tests for this package will start failing once PHPCompatibility addresses this. Ref: * symfony/polyfill 546 * symfony/polyfill@7846989
Member
Author
|
Note: this should be the last PR in the series to fix the CI build failure. |
Member
Author
|
Hmm... okay, the last one related to PHP 8.4.... Now off to pull the PRs for PHP 8.5.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of version v1.34.0, the BCMath
bcceil(),bcfloor()andbcround()functions, as introduced in PHP 8.4, are now included in the Symfony polyfill.Note: the upstream commit also polyfills the PHP
RoundingModeenum, however, PHPCompatibility doesn't detect this yet, so this will need to be dealt with at a later point in time once it becomes clear how PHPCompatibility will report on this. A test for the enum has been added to ensure that the tests for this package will start failing once PHPCompatibility addresses this.Ref: