Skip to content

PHP 8.3/8.4/8.5 polyfill ruleset: update inline documentation #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrfnl merged 3 commits into from
Jun 21, 2026
+6 −16
Merged

PHP 8.3/8.4/8.5 polyfill ruleset: update inline documentation #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
446ccdf
PHP 8.3 polyfill ruleset: update inline documentation
jrfnl Jun 21, 2026
2531ce5
PHP 8.4 polyfill ruleset: update inline documentation
jrfnl Jun 21, 2026
9c35629
PHP 8.5 polyfill ruleset: fix inline documentation
jrfnl Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions PHPCompatibilitySymfonyPolyfillPHP83/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

<rule ref="PHPCompatibility">
<!-- https://github.com/symfony/polyfill-php83/blob/1.x/bootstrap.php -->
<!-- https://github.com/symfony/polyfill-php83/blob/1.x/bootstrap72.php -->
<!-- https://github.com/symfony/polyfill-php83/blob/1.x/bootstrap81.php -->
<exclude name="PHPCompatibility.FunctionUse.NewFunctions.json_validateFound"/>
<exclude name="PHPCompatibility.FunctionUse.NewFunctions.mb_str_padFound"/>
<exclude name="PHPCompatibility.FunctionUse.NewFunctions.stream_context_set_optionsFound"/>
Expand Down Expand Up @@ -77,20 +79,12 @@
<exclude-pattern>/polyfill-php83/bootstrap81\.php$</exclude-pattern>
</rule>

<!--
Not a false positive, but a bug in the Symfony PHP 8.3 polyfill package.
Bug has been reported: https://github.com/symfony/polyfill/issues/499#issuecomment-3430297592
Temporarily silencing the error as this needs to be solved upstream.
-->
<!-- Version toggle present. See: https://github.com/symfony/polyfill/pull/501 -->
<rule ref="PHPCompatibility.Classes.NewClasses.valueerrorFound">
<exclude-pattern>/polyfill-php83/Php83\.php$</exclude-pattern>
</rule>

<!--
Not a false positive, but a bug in the Symfony PHP 8.3 polyfill package.
Bug has been reported: https://github.com/symfony/polyfill/issues/550
Temporarily silencing the error as this needs to be solved upstream.
-->
<!-- See: https://github.com/symfony/polyfill/pull/594 -->
<rule ref="PHPCompatibility.FunctionUse.NewFunctionParameters.ldap_exop_controlsFound">
<exclude-pattern>/polyfill-php83/bootstrap\.php$</exclude-pattern>
</rule>
Expand Down
6 changes: 1 addition & 5 deletions PHPCompatibilitySymfonyPolyfillPHP84/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,7 @@
<exclude-pattern>/polyfill-php84/Resources/RoundingMode\.php$</exclude-pattern>
</rule>

<!--
Not a false positive, but a bug in the Symfony PHP 8.4 polyfill package.
Bug has been reported: https://github.com/symfony/polyfill/issues/499#issuecomment-3430423298
Temporarily silencing the error as this needs to be solved upstream.
-->
<!-- Version toggle present. See: https://github.com/symfony/polyfill/pull/501 -->
<rule ref="PHPCompatibility.Classes.NewClasses.valueerrorFound">
<exclude-pattern>/polyfill-php84/Php84\.php$</exclude-pattern>
</rule>
Expand Down
2 changes: 1 addition & 1 deletion PHPCompatibilitySymfonyPolyfillPHP85/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<exclude name="PHPCompatibility.Classes.NewClasses.filter_filterfailedexceptionFound"/>
</rule>

<!-- Prevent false positives being thrown when run over the code of polyfill-php84 itself. -->
<!-- Prevent false positives being thrown when run over the code of polyfill-php85 itself. -->
<rule ref="PHPCompatibility.Attributes.NewAttributes.PHPNativeAttributeFound">
<exclude-pattern>/polyfill-php85/Resources/stubs/DelayedTargetValidation\.php$</exclude-pattern>
<exclude-pattern>/polyfill-php85/Resources/stubs/NoDiscard\.php$</exclude-pattern>
Expand Down
Loading