Refactor Redis driver to read all keys efficiently#913
Refactor Redis driver to read all keys efficiently#913Geolim4 merged 7 commits intoPHPSocialNetwork:masterfrom
Conversation
The Redis driver's function to read all keys has been streamlined. The changes include removing the check for iterable and adding a loop to scan and merge the keys iteratively. This ensures that the function will work correctly, even when the number of keys retrieved exceeds the MAX_ALL_KEYS_COUNT.
Where did you see that ? From which version ? |
|
I'm sorry for the not so good PR comment. By |
|
I just read this in the docs:
I now understand the purpose of this PR. I'll check it asap. |
|
It should be fixed. I've also made the same changed in the rediscluster driver |
|
Hello, thanks but the quality tools does not pass, please run them locally before pushing: https://github.com/PHPSocialNetwork/phpfastcache/blob/master/CONTRIBUTING.md#developer-notes |
|
Can you fix the CI @mapcentia ? |
|
thank you ! |
The Redis driver's function to read all keys has been streamlined. The change is adding a loop to scan and merge the keys iteratively. This ensures that the function will work correctly, even when the number of keys scanned exceeds the MAX_ALL_KEYS_COUNT.
Proposed changes
This is a fix for #912
Types of changes
What types of changes does your code introduce to Phpfastcache?
Agreement
I have read the CONTRIBUTING and CODING GUIDELINE docs