fix(ci): guard fromJSON against empty release PR output#91
Merged
Conversation
The release-please workflow failed template validation on runs where no
release PR exists (e.g. the release/merge run): steps.release.outputs.pr
is an empty string, and a step's env: expressions are evaluated even when
the step is skipped by its if: guard, so fromJSON('') raised
"Error reading JToken from JsonReader."
Short-circuit the expression so fromJSON is only called when pr is set.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Deploying chat-widget with
|
| Latest commit: |
0c00839
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c7968422.chat-widget-ejc.pages.dev |
| Branch Preview URL: | https://fix-release-please-fromjson.chat-widget-ejc.pages.dev |
PAMulligan
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
release-pleaseworkflow failed with:On runs where release-please does not maintain a release PR (e.g. the release/merge run),
steps.release.outputs.pris an empty string. A step'senv:expressions are evaluated even when the step is skipped by itsif:guard, sofromJSON('')throws. (The identicalfromJSONon line 35 is safe becausewith:inputs are only evaluated when the step actually runs.)Fix
Short-circuit the expression so
fromJSONis only invoked whenpris non-empty:🤖 Generated with Claude Code