chore: bump the patch group across 1 directory with 2 updates#6062
chore: bump the patch group across 1 directory with 2 updates#6062dependabot[bot] wants to merge 1 commit into
Conversation
CI failed — test-msrv: indexmap 2.14.0 and hashbrown 0.17.1 require Rust 1.85, above prqlc's MSRV of 1.81.0. Dismissing pending a fix.
prql-bot
left a comment
There was a problem hiding this comment.
This bump can't land as-is: test-msrv fails because it forces prqlc's transitive dependencies above the workspace MSRV of 1.81.0 (rust-version in the root Cargo.toml).
The chain is unavoidable — it's not just collateral re-resolution that can be pinned away:
mdbook-core0.5.4 requirestoml ^1.1.2(0.5.2 requiredtoml ^0.9.8).toml1.1.2 requiresindexmap ^2.13.0.indexmap2.13.0 declaresrust-version = 1.82, and the default resolution picks 2.14.0 (1.85), which pullshashbrown0.17.1 (1.85).
Since Cargo unifies indexmap/hashbrown to a single version across the workspace, prqlc (which reaches indexmap via serde_yaml) inherits the raised MSRV and fails cargo msrv verify. I confirmed there's no pin that keeps both mdbook 0.5.4 and MSRV 1.81 — cargo update -p indexmap --precise 2.11.4 errors on toml's ^2.13.0 requirement.
So this is a policy call rather than a mechanical fix — flagging for a maintainer:
- Raise the MSRV. Bump
rust-versionin the rootCargo.toml. Minimum viable is1.82(also pinindexmapto=2.13.0inCargo.lockto avoid the jump to1.85that 2.14 + hashbrown 0.17 would otherwise require). This is a public commitment change for all prqlc consumers. - Hold this update. Keep
mdbook-core/mdbook-preprocessorat 0.5.2 (toml 0.9) to preserve MSRV 1.81, and close/ignore the bump until the MSRV policy is revisited.
I didn't push either change since raising the MSRV is a deliberate policy decision. Happy to push whichever you prefer.
Verification
indexmap 2.11.4 -> rust-version 1.63
indexmap 2.12.0 -> rust-version 1.82
indexmap 2.13.0 -> rust-version 1.82
indexmap 2.14.0 -> rust-version 1.85
hashbrown 0.16.1 -> rust-version 1.65
hashbrown 0.17.1 -> rust-version 1.85
cargo update -p indexmap@2.14.0 --precise 2.11.4:
error: failed to select a version for the requirement `indexmap = "^2.13.0"`
candidate versions found which didn't match: 2.11.4
required by package `toml v1.1.2+spec-1.1.0`
... which satisfies dependency `toml = "^1.1.2"` of package `mdbook-core v0.5.4`
MSRV failure (test-msrv job): Crate source was found to be incompatible with its MSRV '1.81.0', as defined in 'prqlc/prqlc/Cargo.toml'.
Bumps the patch group with 2 updates in the / directory: [mdbook-core](https://github.com/rust-lang/mdBook) and [mdbook-preprocessor](https://github.com/rust-lang/mdBook). Updates `mdbook-core` from 0.5.2 to 0.5.4 - [Release notes](https://github.com/rust-lang/mdBook/releases) - [Changelog](https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md) - [Commits](rust-lang/mdBook@v0.5.2...v0.5.4) Updates `mdbook-preprocessor` from 0.5.2 to 0.5.4 - [Release notes](https://github.com/rust-lang/mdBook/releases) - [Changelog](https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md) - [Commits](rust-lang/mdBook@v0.5.2...v0.5.4) --- updated-dependencies: - dependency-name: mdbook-core dependency-version: 0.5.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch - dependency-name: mdbook-preprocessor dependency-version: 0.5.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch ... Signed-off-by: dependabot[bot] <support@github.com>
c436697 to
5cb90ba
Compare
Bumps the patch group with 2 updates in the / directory: mdbook-core and mdbook-preprocessor.
Updates
mdbook-corefrom 0.5.2 to 0.5.4Release notes
Sourced from mdbook-core's releases.
Changelog
Sourced from mdbook-core's changelog.
... (truncated)
Commits
2ea30c0Merge pull request #3155 from ehuss/bump-versiona08ba2bBump version to 0.5.40e5ddf6Merge pull request #3154 from ehuss/ci-version-stringf4ddbffShow the correct version in CI install docs8b53f1bMerge pull request #3127 from GuillaumeGomez/zoom-inbeab2faMention zoom-in feature in mdbook guide588066cMake the "zoom in" feature work with keyboard and simplify DOMf526b18Only enable "zoom-in" feature on images not inside links73d6edfAdd possibility to "zoom out" using the escape key6a7ef4dAdd regression test for the "zoom-in" featureUpdates
mdbook-preprocessorfrom 0.5.2 to 0.5.4Release notes
Sourced from mdbook-preprocessor's releases.
Changelog
Sourced from mdbook-preprocessor's changelog.
... (truncated)
Commits
2ea30c0Merge pull request #3155 from ehuss/bump-versiona08ba2bBump version to 0.5.40e5ddf6Merge pull request #3154 from ehuss/ci-version-stringf4ddbffShow the correct version in CI install docs8b53f1bMerge pull request #3127 from GuillaumeGomez/zoom-inbeab2faMention zoom-in feature in mdbook guide588066cMake the "zoom in" feature work with keyboard and simplify DOMf526b18Only enable "zoom-in" feature on images not inside links73d6edfAdd possibility to "zoom out" using the escape key6a7ef4dAdd regression test for the "zoom-in" feature