refine: avoid full Func clone and fix comment typo in resolver#6068
Open
prql-bot wants to merge 1 commit into
Open
refine: avoid full Func clone and fix comment typo in resolver#6068prql-bot wants to merge 1 commit into
prql-bot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small cleanups in
semantic/resolver/functions.rs, found in the nightly code-quality sweep.expr_of_func:func.clone().body.tydeep-cloned the entireFunc(params, args, body, env, name hints) only to readbody.ty, then discarded the clone. Replaced withfunc.body.ty.clone(), which clones just theOption<Ty>. Behavior is identical —funcitself is still moved intoExprKind::Func(func)a few lines later, so nothing else changes.Err(func)is partial application is required" → "if partial application is required".No regression test is included: the clone change is a pure allocation optimization that yields the same value, and the other change is a comment fix. Both are covered by the existing resolver test suite (
cargo test -p prqlc --lib resolver, all passing).