Skip to content

feature-client#2-LoginWechat#12

Open
yidanwang214 wants to merge 7 commits into
mainfrom
feature-client#2-LoginWechat
Open

feature-client#2-LoginWechat#12
yidanwang214 wants to merge 7 commits into
mainfrom
feature-client#2-LoginWechat

Conversation

@yidanwang214

Copy link
Copy Markdown

Finished fundamental html and css for feature-client#2-LoginWechat.

Potential problems:

  1. The code format might be problematic in that the SVG elements are mingled with inline CSS. Other than that, CSS for other elements is written in a stand-alone login.css file.
  2. The layout of the login page is not identical to the design on Figma due to the lack of information such as the margin between different features.

Will work on the <script> section later this week.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以改成scss写起来方便很多

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到。我争取明天改一下。

Comment thread pte-app-client/pages/login/login.css Outdated
font-weight: 500;
line-height: normal;
letter-spacing: 0.24px;
/* width: 23.4375rem;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment不用可以去掉

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sir.

@RuntaoZhuge

Copy link
Copy Markdown
Member

Finished fundamental html and css for feature-client#2-LoginWechat.

Potential problems:

  1. The code format might be problematic in that the SVG elements are mingled with inline CSS. Other than that, CSS for other elements is written in a stand-alone login.css file.
  2. The layout of the login page is not identical to the design on Figma due to the lack of information such as the margin between different features.

Will work on the <script> section later this week.

I also realized that Dcloud does have a UI lib called MUI (weirdly) which would provide us some existing functions we can use so we don't have to set up everything again

Dcloud MUI

Comment thread pte-app-client/pages/login/login.vue Outdated
viewBox="0 0 24 20"
fill="none"
>
<path

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can download the svg and put into another folder and put the reference here

Comment thread pte-app-client/pages/login/login.css Outdated
font-style: normal;
font-weight: 500;
line-height: normal;
letter-spacing: 0.24px;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kind of hardcoding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants