-
Notifications
You must be signed in to change notification settings - Fork 38
chore(deps): enroll 47 third-party packages into Bun workspace catalog #2416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a73ed22
chore(deps): enroll 47 third-party packages into Bun workspace catalog
andrew-bierman 858e068
fix(guides): remove standalone bun.lock that broke Cloudflare Pages c…
andrew-bierman f06c368
fix(ci): add CF Pages-specific error message for missing GitHub Packa…
andrew-bierman b2fe566
fix(deps): replace vitest version pins with catalog: in landing and g…
andrew-bierman f16805f
fix(api): lower cpu_ms limit to 300000 — CF max is 300 s not 400 s
andrew-bierman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded CF Pages project name may cause confusion.
Line 58 hardcodes "packrat-guides" in the navigation path. If other apps in this monorepo are also deployed to CF Pages, this instruction will be incorrect for those builds.
CF Pages typically provides a
CF_PAGES_PROJECT_NAMEenvironment variable. Consider either:📝 Proposed fix to make the path generic
Or with dynamic project name:
console.error('Add it as an environment variable in the CF Pages project settings:'); + const projectName = process.env.CF_PAGES_PROJECT_NAME || '[your-project]'; console.error( - ' dash.cloudflare.com → Pages → packrat-guides → Settings → Environment variables', + ` dash.cloudflare.com → Pages → ${projectName} → Settings → Environment variables`, );🤖 Prompt for AI Agents