fix(expo): improve pack selection UX and dynamic API base URL#2524
Conversation
- Rename "Pack Name" header to "Choose a Pack" for clearer intent
- Refactor PackSelectionScreen to use FlatList as root; sticky search bar
- Move "ADDING" item card (with image) from PackSelectionScreen to AddCatalogItemDetailsScreen
- Remove "Change pack" button from AddCatalogItemDetailsScreen pack card
- Add edges={['bottom']} to CatalogItemDetailScreen SafeAreaView
- Switch apiClient and authClient to getApiBaseUrl() helper
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (7)
WalkthroughThe PR refactors catalog screens with a new header-based item layout and removes unnecessary catalog-detail dependencies from pack selection. It also adds Android-specific API URL handling to rewrite localhost to the emulator bridge address (10.0.2.2). ChangesAndroid API Base URL Handling
Catalog Screens UI Refactoring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
FlatListwith sticky search bar, moved the "ADDING" item card (with image) to the details screenclientEnvs.EXPO_PUBLIC_API_URLaccess with agetApiBaseUrl()helper that rewriteslocalhost → 10.0.2.2on Android emulatorsedges={['bottom']}toSafeAreaViewTest plan
10.0.2.2Summary by CodeRabbit
New Features
Bug Fixes
UI/UX Improvements