chore(deps): bump @packrat-ai/nativewindui 2.0.3 → 2.0.6, drop local patches#2528
Merged
Merged
Conversation
Contributor
|
Warning Review limit reached
More reviews will be available in 18 minutes and 52 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
dependencies
Contributor
Coverage Report for API Unit Tests Coverage (./packages/api)
File CoverageNo changed files found. |
Contributor
Coverage Report for Expo Unit Tests Coverage (./apps/expo)
File CoverageNo changed files found. |
Contributor
There was a problem hiding this comment.
Pull request overview
Bumps @packrat-ai/nativewindui from 2.0.3 to 2.0.6 and removes the local patch that's now obsolete since upstream 2.0.6 ships the testID propagation and TypeScript fixes the patch was working around.
Changes:
- Update root
overridespin (2.0.3→2.0.6) and root direct dep range (^2.0.3→^2.0.6); empty thepatchedDependenciesblock. - Refresh
bun.lockto resolve@packrat-ai/nativewindui@2.0.6from GitHub Packages. - Delete
patches/@packrat-ai%2Fnativewindui@2.0.3.patch.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Bumps override and direct dep to 2.0.6; clears the patchedDependencies entry. |
| bun.lock | Lockfile refresh resolving 2.0.6 and dropping the patch entry. |
| patches/@PackRat-AI%2Fnativewindui@2.0.3.patch | Deleted — fixes (testID propagation, type corrections) now present upstream. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrew-bierman
force-pushed
the
chore/bump-nativewindui-2.0.6
branch
from
48a237e to
539ccbf
Compare
…cal patches
Upstream `@packrat-ai/nativewindui@2.0.6` ships everything the local patch
was working around:
- LargeTitleHeader: `testID={props.searchBar.testID}` on the search-icon
Button (the catalog-search testID fix we added in PR #2511).
- Type fixes from `chore: fix type issues` + `🏷️ fix all TypeScript errors
after fresh component sync` that made the local `@ts-nocheck` hunks on
AdaptiveSearchHeader / Icon/types / LargeTitleHeader obsolete.
Changes:
- `packages/ui/package.json` is already the canonical declarer at `^2.0.6`.
- **Drop the root `overrides` pin** for nativewindui. It was added in
`8a558939e` to freeze us at 2.0.3 because 2.0.6 had a type regression
against react-native 0.81 autocapitalize types. We're on RN 0.83.6 now,
the regression no longer reproduces, and overrides should be reserved
for emergency pins, not normal version management. With the override
gone, the `^2.0.6` range in `packages/ui` is the single source of
truth — future releases bump naturally without touching the root.
- Empty `patchedDependencies` block and delete the patch file — nothing
to patch against 2.0.6.
Verified:
- `bun install` resolves to 2.0.6 cleanly with no root override.
- `bunx tsc --noEmit` clean on `apps/expo` (only the pre-existing `uuid`
type-def error remains, unrelated).
- Playwright web E2E suite is 36/36 green against 2.0.6 with no patches.
andrew-bierman
force-pushed
the
chore/bump-nativewindui-2.0.6
branch
from
539ccbf to
48815c4
Compare
andrew-bierman
added a commit
that referenced
this pull request
Jun 1, 2026
Resolution strategy (per fly-on-the-wall rule — development's bug fixes win
for everything except the e2e test infrastructure itself):
* App code conflicts (ai-chat.tsx, _layout.tsx, one-time-password.tsx,
UserAvatar.tsx, pack/trip components, hooks, trips route): take theirs.
* packages/api/src/db/seed-e2e-user.ts: take theirs — uses accountId=email
(better-auth's actual lookup key) and proper .onConflictDoUpdate().
* .github/workflows/web-e2e-tests.yml: take theirs — adds e2e-gate job,
smart path filters, and a 'seed E2E user' step.
* apps/expo/playwright/{playwright.config.ts,tests/*.ts}: take ours.
Development's parallel attempt still uses retired /api/auth/login etc;
ours is the working 36/36 Better Auth suite from #2511.
* Root package.json: keep our #2528 cleanup — drop the
'@packrat-ai/nativewindui: 2.0.3-2' override block, keep
'patchedDependencies: {}'.
* packages/ui/package.json: take ours (^2.0.6).
* bun.lock: regenerated via 'bun install'.
* packages/api/src/db/seed-e2e-catalog.ts: switch import from local
'./schema' to '@packrat/db/schema' — development moved the schema
into the @packrat/db workspace.
Verified:
* bun test:expo — 357/357
* bun test:api:unit — 328/328
* bun check-types — 0 errors
* @packrat-ai/nativewindui resolves to 2.0.6
andrew-bierman
added a commit
that referenced
this pull request
Jun 1, 2026
development advanced by 1010 commits since our last merge, largely landing the same web-support work via #2366 plus the turborepo migration #2200, @packrat/typescript-config #2527, per-package check-types #2532, bun pin via .tool-versions #2534, and the schemas refactor 0cdf8b2. Conflict resolution policy: - Take development's version everywhere by default (fly on the wall). - Take HEAD only for files that carry post-merge fixes unique to this branch, i.e. the three commits ab6328e / 006bcdd / 522c805: apps/expo/lib/api/packrat.ts (web token cache), apps/expo/lib/auth-client.ts (credentials:include), apps/expo/mocks/react-native-community-datetimepicker.tsx (forward testID), apps/expo/providers/index.web.tsx (BottomSheet + ActionSheet), apps/expo/features/trips/hooks/useDeleteTrip.ts (DELETE via apiClient), apps/expo/features/trips/screens/TripDetailScreen.tsx (window.confirm on web), apps/expo/playwright/tests/trips.spec.ts (date-input via forwarded testID + DELETE wait + explicit goto), apps/expo/app/(app)/ ai-chat.tsx (async headers + tokenRef), packages/api/src/auth/index.ts (rate limit disabled on localhost). - Root package.json: keep our kysely override + drop the now-unused patchedDependencies block + drop development's nativewindui 2.0.3-2 pin (we're on 2.0.6 via #2528). Regenerated bun.lock. - Removed the orphan patches/@PackRat-AI%2Fnativewindui@2.0.3.patch brought back by the modify/delete conflict (no longer referenced from package.json).
andrew-bierman
added a commit
that referenced
this pull request
Jun 1, 2026
Brought back by the modify/delete conflict in the development merge but no longer referenced from package.json (we're on ^2.0.6 via #2528 where the upstream fix landed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream
@packrat-ai/nativewindui@2.0.6ships everything the local patch was working around, so we can bump and delete the patch file entirely.What's in 2.0.6 that makes the patch obsolete
searchBar.testIDnever propagated to the search-icon Button inLargeTitleHeader(brokecatalog-searchPlaywright test)patches/@packrat-ai%2Fnativewindui@2.0.3.patch(added in #2511)feat: expose testIDs across all components(commitefb2492/a94b14c)// @ts-nocheckbecause the published types didn't match the runtime shape@ts-nocheckhunks onAdaptiveSearchHeader,Icon/types,LargeTitleHeaderchore: fix type issues(commit1480564) +🏷️ fix all TypeScript errors after fresh component sync(commit5e02035)Diff scope
package.json— rootoverridespin (2.0.3→2.0.6), root direct dep range (^2.0.3→^2.0.6),patchedDependenciesblock emptied.packages/ui/package.jsonwas already declaring^2.0.6but the override + root range pinned us back to 2.0.3, which is why nobody was getting the upstream fix.bun.lock— refreshed bybun installto pull2.0.6from GitHub Packages.patches/@packrat-ai%2Fnativewindui@2.0.3.patch— deleted.Verification
bun installresolves to@packrat-ai/nativewindui@2.0.6cleanly.bunx tsc --noEmitis clean onapps/expo(one pre-existinguuidtype-def error, unrelated to this change).bun test:expo(326/326) andbun test:api:unit(215/215) both green.Risk
Low — additive feature release upstream, no API breaks. The
LargeTitleHeaderfile also got a formatting pass (single quotes, trailing commas, JSX line wrapping) but no behavioural changes. iOS / Maestro flows aren't affected (no.maestro/**files touched, and the only runtime difference is the testID lands on the actual DOM element on web/Android).Follow-up
Going forward we should bump the
@packrat-ai/nativewinduiminor version (2.1.0) when shipping accumulated user-visible features rather than patch (2.0.7). Patches feel "should already have" and quietly didn't land here — the rootoverridespin sailed past thepackages/ui^2.0.6range without anyone noticing until I went looking.