TASK Binary expression ast with only two operands: left and right

[mhsdesign]

... instead of multiple operands

i inlined $left and $right into the BinaryOperationNode:

final class BinaryOperationNode
{
    private function __construct(
        public readonly ExpressionNode $left,
        public readonly BinaryOperator $operator,
        public readonly ExpressionNode $right
    ) {
    }
}

this will make working with the BinaryOperandNode (eg type resolving/narrowing) much easier.
Also the php and js AST also use the fields $left $right and $operator instead of a collection (even when the same operator is used).

as a sideeffect we now also transpile true === true === true correctly to php (by wrapping it in parenthesis): (true === true) === true
without parenthesis it is not valid php (its valid ecmascript though ^^)

The above mentioned case with === true is obviously an edge case and currently 1 + 1 + 1 is also transpiled with parenthesis: (1 + 1) + 1 which are optional and not needed by php - we still need to decide if we like this see #16 (comment).

[mhsdesign]

if you prefer not having those parenthesis here, i experimented with a shouldAddParenthesisIfNecessary flag, this way we could transpile without parenthesis (if the operand is the same in chained binary ops)

public function transpile(BinaryOperationNode $binaryOperationNode): string
{
    $expressionTranspiler = new ExpressionTranspiler(
        scope: $this->scope,
        shouldAddQuotesIfNecessary: true,
        shouldAddParenthesisIfNecessary: !(
            $binaryOperationNode->operands->first->root instanceof BinaryOperationNode
            && $binaryOperationNode->operands->first->root->operator === $binaryOperationNode->operator
        )
    );

    $first = $expressionTranspiler->transpile($binaryOperationNode->operands->first);
    $operator = $this->transpileBinaryOperator($binaryOperationNode->operator);
    $second = $expressionTranspiler->transpile($binaryOperationNode->operands->second);

    if ($this->shouldAddParenthesis) {
        return sprintf('(%s %s %s)', $first, $operator, $second);
    } else {
        return sprintf('%s %s %s', $first, $operator, $second);
    }
}

[grebaldi]

I don't mind those :) All's good 👍

[mhsdesign]

This pr will also make implementing #8 and #14 easier

[grebaldi]

• Tests are green
• One fewer class
• Waaaay better, semantically
• Everything gets easier

What's not to like? 😃

Thanks a lot @mhsdesign!

[mhsdesign]

:D