Updated text and method naming#1
Open
Nicolai1205 wants to merge 1 commit intoPacktPublishing:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently bought the book and was enjoying browsing through it.
I noticed several methods used from the web3 package were deprecated or has been renamed in recent updates.
As such I want to assist in updating these going forward and the change to this one file was merely a test.
examples:
Methods such as "fromWei" have been updated to fit current notation as "from_wei"
Method "web3.isConnected()" changed to ned notation "web3.is_connected()"
Added additional note explaining the user/learner needs to get their own RPC server address from Ganache.