【Hackathon 10th Spring No.51】[ThirdParty] Bump yaml-cpp version to 0.9.0 - part 4#79229
【Hackathon 10th Spring No.51】[ThirdParty] Bump yaml-cpp version to 0.9.0 - part 4#79229gouzil wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR appears to update Paddle’s third_party/yaml-cpp submodule to yaml-cpp-0.9.0 to address GCC 15 build compatibility (Environment Adaptation / Devs).
Changes:
- Bump
third_party/yaml-cpptoyaml-cpp-0.9.0. - Adjust build integration as needed to resolve GCC 15 compilation issues (details not visible from the provided input).
Limitation: the actual diff hunks / changed-file list were not included in the prompt, and the checkout’s third_party/yaml-cpp/ directory is empty in this environment (likely due to submodules not being populated here). Without the diff hunks (or at least the list of changed files + changed line ranges), I can’t place line-accurate PR review comments or verify what GCC15-specific changes were made.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PaddlePaddle-bot
left a comment
There was a problem hiding this comment.
🤖 Paddle-CI-Agent | pr_review |
2026-06-03 14:16:36
📋 Review 摘要
PR 概述:将 third_party/yaml-cpp submodule 指针更新至 yaml-cpp-0.9.0(commit 1ecfeb8c),解决 gcc 15 编译兼容性问题。
变更范围:third_party/yaml-cpp
影响面 Tag:[Build] [ThirdParty]
问题
未发现阻塞性问题。PR 规范问题在下面章节报,不要在这里重复。
历史 Findings 修复情况
| Finding | 问题 | 状态 |
|---|---|---|
| PR 规范 | 标题含非标准前缀 【Hackathon 10th Spring No.51】,Tag [ThirdParty] 不在官方枚举列表 |
📝 PR 规范检查
PR 描述结构合规,四个必填 section 均已填写。标题存在两处不规范:①含非标准前缀 【Hackathon 10th Spring No.51】;② Tag [ThirdParty] 不在 checklist §D1/§D2 枚举列表中(官方 Tag 来自 PR Category 或 PR Types),按 diff 影响面正确 Tag 应为 [Environment Adaptation]。
标题建议(可直接复制):
[Environment Adaptation] Bump yaml-cpp version to 0.9.0 (part 4)
PR 描述建议(点击展开,可直接复制)
### PR Category
<!-- One of [ User Experience | Execute Infrastructure | Operator Mechanism | CINN | Custom Device | Performance Optimization | Distributed Strategy | Parameter Server | Communication Library | Auto Parallel | Inference | Environment Adaptation ] -->
Environment Adaptation
### PR Types
<!-- One of [ New features | Bug fixes | Improvements | Performance | BC Breaking | Deprecations | Docs | Devs | Not User Facing | Security | Others ] -->
Devs
### Description
<!-- Describe what you've done -->
* 将 `third_party/yaml-cpp` 子模块更新到 `yaml-cpp-0.9.0`(commit `1ecfeb8c4cee7b0ae765579385064521871aa925`)
* 解决 gcc 15 编译兼容性问题
相关链接:
* https://github.com/jbeder/yaml-cpp/issues/1307
* https://gcc.gnu.org/cgit/gcc/commit/?id=3a817a4a5a6d94da9127af3be9f84a74e3076ee2
### 是否引起精度变化
<!-- one of the following [ 是 | 否 ]-->
否总体评价
纯 submodule 指针更新,变更内容简洁清晰,目标版本 yaml-cpp-0.9.0 已修复 gcc 15 兼容性问题。建议修正标题 Tag 后合入。
|
@gouzil 已排查当前 head Windows-GPU 指定 job 结论:和 yaml-cpp 更新直接相关,不是 flaky/infra。 证据:指定 job 对应 yaml-cpp commit 其它失败分类:
修复方向:先修 yaml-cpp 这个 submodule commit 的 Windows 兼容性,例如让 目前我没有 rerun:Windows 失败是确定代码问题,rerun 会复现;Coverage/Linux-CPU/DCU 是无关 infra,但 PR 仍被 Windows 代码问题阻塞,先不刷 CI。 |
|
@ShigureNyako 你看看 yaml-cpp 是不是已经不支持 MSVC2017 了 |
|
@gouzil 我看了下,更准确的结论是:不能把当前选的 yaml-cpp commit 当作支持 MSVC2017 使用;但这不完全等同于 几点证据:
所以我建议不要直接用当前
|
|
see: #79233 |
PR Category
Environment Adaptation
PR Types
Devs
Description
third_party/yaml-cpp子模块更新到yaml-cpp-0.9.0相关链接:
是否引起精度变化
否