Skip to content

[CodeStyle][Ast-grep] Bump ast-grep to v0.44.0#79382

Merged
SigureMo merged 1 commit into
PaddlePaddle:developfrom
ShigureNyako:codestyle/weekly-tooling-upgrade-20260627
Jun 27, 2026
Merged

[CodeStyle][Ast-grep] Bump ast-grep to v0.44.0#79382
SigureMo merged 1 commit into
PaddlePaddle:developfrom
ShigureNyako:codestyle/weekly-tooling-upgrade-20260627

Conversation

@ShigureNyako

@ShigureNyako ShigureNyako commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

PR Category

User Experience

PR Types

Devs

Description

升级代码风格检查使用的 ast-grepv0.44.0

  • .pre-commit-config.yamlPFCCLab/ast-grep-pre-commit-mirror 更新到 v0.44.0
  • 将 Codestyle-Check workflow 中用于 ast-grep testast-grep-cli 更新到 0.44.0

同步说明:PaddlePaddle/docs#7908 已追加普通增量 commit,将代码风格指南中的 ast-grep 版本同步到 0.44.0

本地验证:

  • ast-grep test
  • pre-commit run ast-grep --all-files
  • git diff --check -- .pre-commit-config.yaml .github/workflows/Codestyle-Check.yml

是否引起精度变化

@ShigureNyako

Copy link
Copy Markdown
Contributor Author

@SigureMo 麻烦 review。

已自查:本 PR 只升级 ast-grep 相关版本,diff 限于两处:

  • .pre-commit-config.yaml: PFCCLab/ast-grep-pre-commit-mirror v0.42.1 -> v0.44.0
  • .github/workflows/Codestyle-Check.yml: ast-grep-cli==0.42.1 -> 0.44.0

本地验证已通过:

  • ast-grep test
  • pre-commit run ast-grep --all-files
  • git diff --check -- .pre-commit-config.yaml .github/workflows/Codestyle-Check.yml

同步说明:PaddlePaddle/docs#7908 已追加增量 commit,将代码风格指南中的 ast-grep 版本同步到 0.44.0

CI 初步状态:Pre Commit 已通过;PR 模板第一次因 PR Types 写成组合值失败,已修正为 Devs,新一轮 Check 已通过;其他流水线仍在运行中。

@risemeup1111 risemeup1111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

未发现代码改动本身需要阻塞合入的问题;Pre Commit 中的 ast-grep 0.44.0 测试和 hook 均已通过。还有一个 PR 描述字段导致模板检查失败,需要在合入前修正:

  • P3 优先级:P3 非行级:PR 描述不在 diff 中。当前 Check PR Template 失败,日志显示 PR Types 的值为 Devs / Not User Facing,但模板检查只接受逗号分隔的枚举项。请将 PR 描述里的 ### PR Types 改为 Devs, Not User Facing,让模板检查恢复通过。
Powered by Nyanpasu with gpt-5.5 xhigh, please check the suggestions carefully.

@risemeup1111 risemeup1111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已复查更新后的 PR 描述,之前 PR Types 导致模板检查失败的问题已解决;后续 Check PR Template 也已通过。当前 diff 仍是 ast-grep 版本同步,未发现需要阻塞合入的代码问题;剩余运行中的 CI 以最终结果为准。

Powered by Nyanpasu with gpt-5.5 xhigh, please check the suggestions carefully.

@SigureMo SigureMo merged commit 02ef364 into PaddlePaddle:develop Jun 27, 2026
83 of 84 checks passed
@SigureMo SigureMo deleted the codestyle/weekly-tooling-upgrade-20260627 branch June 27, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants