feat: add sorting capabilities to service mapping table#136
Merged
jhfgloria merged 3 commits intoDEVECO-615/add-filtering-capabilitiesfrom Feb 13, 2026
Merged
Conversation
Implement comprehensive sorting functionality for the service mapping table, allowing users to sort by name, team, service name, status, and account. Backend changes: - Add sort parameter validation in mappings controller - Implement compareEntities function with proper field mapping - Force post-processing for consistent sorting across all fields - Add STATUS_ORDER for proper status sorting (ErrorWhenFetchingService < NotMapped < OutOfSync < InSync) Frontend changes: - Update API client to pass sort parameters to backend - Update type definitions to include sort in getEntityMappingsWithPagination - Add ErrorWhenFetchingService to FormattedBackstageEntity status type Testing: - Add backend tests for sort parameter validation - Add frontend component tests for sort functionality - Test sort with filters and pagination Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jhfgloria
force-pushed
the
DEVECO-615/add-sorting-capabilities
branch
from
60d7e1e to
e6b5e8b
Compare
jhfgloria
changed the base branch from
main
to
DEVECO-615/add-filtering-capabilities
fanfernandes
approved these changes
Feb 11, 2026
plugins/backstage-plugin/src/components/PagerDutyPage/MappingsTable/MappingsTable.test.tsx
Outdated
Show resolved
Hide resolved
sandornagy517
approved these changes
Feb 12, 2026
Contributor
sandornagy517
left a comment
sandornagy517
left a comment
There was a problem hiding this comment.
great job! left 2 questions but feel free to merge!
|
|
||
| const mappingsWithMatchingPagerdutyServices = entityMappings.filter( | ||
| if (matchingPagerDutyServiceIds.length > 0) { | ||
| const mappingsWithMatchingPagerdutyServices = allEntityMappings.filter( |
Contributor
There was a problem hiding this comment.
shouldn't we keep this? we might fetch all entity mappings for no reason
Contributor
Author
There was a problem hiding this comment.
allEntityMappings is eventually used on line 161, no matter the if. This was a refactor, because I realised once I made the changes the request was made twice, one inside the if and another outside, afterwards.
|
|
||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| const changeSort: (s: any) => void = ((sortDescriptor: { column: string; direction: 'ascending' | 'descending' }) => { |
Contributor
There was a problem hiding this comment.
I'm a little bit confused about this, why we have any in there if we define the type right after it for the param?
Contributor
Author
There was a problem hiding this comment.
Argh, because static analysis on onSortChange mandates the use of SortDescriptor... which guess what? Is not exported by the backstage-ui library. It accepts any, tho. The signature like that narrows down a specialisation of the function to have type inference inside it, without breaking the onSortChange signature. 🤷
Fixed inconsistent property name in MappingsTable.test.tsx line 284. Changed 'Sort' to 'sort' to match camelCase convention used throughout the test file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jhfgloria
merged commit 63f3b1f
into
DEVECO-615/add-filtering-capabilities
9 checks passed
jhfgloria
added a commit
that referenced
this pull request
Feb 16, 2026
* feat: add filtering capabilities to service mapping table - Add backend support for filtering by name, service name, and status - Update API client and types to include filters parameter - Implement filter UI with toggle button and filter row - Add name and service filters using SearchField components - Add status filter using Select dropdown - Ensure pagination resets when filters change - Update all tests to include filters parameter - Add new test cases for filter functionality Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> refactor frontend work refactor backend work clean up code team name filter * add team name filter to UI * add account filter * feat: add sorting capabilities to service mapping table (#136) * feat: add sorting capabilities to service mapping table Implement comprehensive sorting functionality for the service mapping table, allowing users to sort by name, team, service name, status, and account. --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> * fix: address pr comments for filtering capabilities - Optimize service filtering by using PagerDuty API query parameter instead of fetching all services and filtering client-side - Extract magic number 10000 to named constant MAX_ENTITIES_FOR_POST_PROCESSING - Remove CatalogApi | undefined type and add guard to ensure catalogApi is required Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: remove redundant comments from pagerduty api Remove redundant "set account" comments that simply restated the code logic. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds comprehensive sorting functionality to the service mapping table, enabling users to sort by name, team, service name, status, and account columns. The sorting implementation includes both frontend UI updates and backend API support with proper validation and testing.
Code Assistance: [x] This PR was code assisted
Affected plugin
Type of change
Checklist
If this is a breaking change 👇
Acknowledgement
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.