feat: Add account selector to the service mappings table#142
Open
sandornagy517 wants to merge 4 commits intoservice_mappigns_featurefrom
Open
feat: Add account selector to the service mappings table#142sandornagy517 wants to merge 4 commits intoservice_mappigns_featurefrom
sandornagy517 wants to merge 4 commits intoservice_mappigns_featurefrom
Conversation
sandornagy517
commented
Feb 26, 2026
| } else if (annotations['pagerduty.com/integration-key']) { | ||
| const integrationKey = annotations['pagerduty.com/integration-key']; | ||
| const account = entity.metadata?.annotations?.['pagerduty.com/account'] || ''; | ||
| const entityAccount = entity.metadata?.annotations?.['pagerduty.com/account'] || ''; |
Contributor
Author
There was a problem hiding this comment.
renamed this since the parent scope we already have a variable called account
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added account filter to the mappings table.
Affected plugin
Type of change
Checklist
If this is a breaking change 👇
Acknowledgement
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.