Skip to content

Snoop the backend's player list header/footer so the proxy's values stay in sync #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WouterGritter wants to merge 2 commits into
base: dev/3.0.0
Choose a base branch
from
+43 −26
Open

Snoop the backend's player list header/footer so the proxy's values stay in sync #1818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f959d9
Snoop the backend's player list header/footer so the proxy's tracked …
WouterGritter May 30, 2026
517a396
Minor changes
WouterGritter May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...src/main/java/com/velocitypowered/proxy/connection/backend/BackendPlaySessionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
import com.velocitypowered.proxy.protocol.packet.ClientboundCookieRequestPacket;
import com.velocitypowered.proxy.protocol.packet.ClientboundStoreCookiePacket;
import com.velocitypowered.proxy.protocol.packet.DisconnectPacket;
import com.velocitypowered.proxy.protocol.packet.HeaderAndFooterPacket;
import com.velocitypowered.proxy.protocol.packet.KeepAlivePacket;
import com.velocitypowered.proxy.protocol.packet.LegacyPlayerListItemPacket;
import com.velocitypowered.proxy.protocol.packet.PluginMessagePacket;
Expand Down Expand Up @@ -338,6 +339,16 @@ public boolean handle(TabCompleteResponsePacket packet) {
return true;
}

@Override
public boolean handle(HeaderAndFooterPacket packet) {
// Snoop the backend's player list header/footer so the proxy's tracked values stay in sync
// with what the player actually sees.
serverConn.getPlayer().setPlayerListHeaderAndFooterSilent(
packet.getHeader().getComponent(),
packet.getFooter().getComponent());
return false;
}

@Override
public boolean handle(LegacyPlayerListItemPacket packet) {
serverConn.getPlayer().getTabList().processLegacy(packet);
Expand Down
6 changes: 6 additions & 0 deletions proxy/src/main/java/com/velocitypowered/proxy/connection/client/ConnectedPlayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,12 @@ public Component getPlayerListFooter() {
return this.playerListFooter;
}

public void setPlayerListHeaderAndFooterSilent(@NonNull final Component header,
@NonNull final Component footer) {
this.playerListHeader = header;
this.playerListFooter = footer;
}

@Override
public void sendPlayerListHeader(@NonNull final Component header) {
this.sendPlayerListHeaderAndFooter(header, this.playerListFooter);
Expand Down
44 changes: 22 additions & 22 deletions proxy/src/main/java/com/velocitypowered/proxy/protocol/StateRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,28 +623,28 @@ public enum StateRegistry {
clientbound.register(
HeaderAndFooterPacket.class,
HeaderAndFooterPacket::new,
map(0x47, MINECRAFT_1_8, true),
map(0x48, MINECRAFT_1_9, true),
map(0x47, MINECRAFT_1_9_4, true),
map(0x49, MINECRAFT_1_12, true),
map(0x4A, MINECRAFT_1_12_1, true),
map(0x4E, MINECRAFT_1_13, true),
map(0x53, MINECRAFT_1_14, true),
map(0x54, MINECRAFT_1_15, true),
map(0x53, MINECRAFT_1_16, true),
map(0x5E, MINECRAFT_1_17, true),
map(0x5F, MINECRAFT_1_18, true),
map(0x60, MINECRAFT_1_19, true),
map(0x63, MINECRAFT_1_19_1, true),
map(0x61, MINECRAFT_1_19_3, true),
map(0x65, MINECRAFT_1_19_4, true),
map(0x68, MINECRAFT_1_20_2, true),
map(0x6A, MINECRAFT_1_20_3, true),
map(0x6D, MINECRAFT_1_20_5, true),
map(0x74, MINECRAFT_1_21_2, true),
map(0x73, MINECRAFT_1_21_5, true),
map(0x78, MINECRAFT_1_21_9, true),
map(0x7A, MINECRAFT_26_1, true));
map(0x47, MINECRAFT_1_8, false),
map(0x48, MINECRAFT_1_9, false),
map(0x47, MINECRAFT_1_9_4, false),
map(0x49, MINECRAFT_1_12, false),
map(0x4A, MINECRAFT_1_12_1, false),
map(0x4E, MINECRAFT_1_13, false),
map(0x53, MINECRAFT_1_14, false),
map(0x54, MINECRAFT_1_15, false),
map(0x53, MINECRAFT_1_16, false),
map(0x5E, MINECRAFT_1_17, false),
map(0x5F, MINECRAFT_1_18, false),
map(0x60, MINECRAFT_1_19, false),
map(0x63, MINECRAFT_1_19_1, false),
map(0x61, MINECRAFT_1_19_3, false),
map(0x65, MINECRAFT_1_19_4, false),
map(0x68, MINECRAFT_1_20_2, false),
map(0x6A, MINECRAFT_1_20_3, false),
map(0x6D, MINECRAFT_1_20_5, false),
map(0x74, MINECRAFT_1_21_2, false),
map(0x73, MINECRAFT_1_21_5, false),
map(0x78, MINECRAFT_1_21_9, false),
map(0x7A, MINECRAFT_26_1, false));
clientbound.register(
LegacyTitlePacket.class,
LegacyTitlePacket::new,
Expand Down
8 changes: 4 additions & 4 deletions proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/HeaderAndFooterPacket.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,10 @@

public class HeaderAndFooterPacket implements MinecraftPacket {

private final ComponentHolder header;
private final ComponentHolder footer;
private ComponentHolder header;
private ComponentHolder footer;

public HeaderAndFooterPacket() {
throw new UnsupportedOperationException("Decode is not implemented");
}

public HeaderAndFooterPacket(ComponentHolder header, ComponentHolder footer) {
Expand All @@ -50,7 +49,8 @@ public ComponentHolder getFooter() {

@Override
public void decode(ByteBuf buf, ProtocolUtils.Direction direction, ProtocolVersion version) {
throw new UnsupportedOperationException("Decode is not implemented");
header = ComponentHolder.read(buf, version);
footer = ComponentHolder.read(buf, version);
}

@Override
Expand Down